Thread: Program to count throws needed for a yahtzee.

I can not understand why you need p_count.
In your function, size is 5. Then you have this (which is the only case returning true)

Code:

for (int j=0;j<size;j++) // Reason that j can not be five!
    {
        if(dice[j]!=dice[j+1])
            break;
        if (j==5) // Can not be five.
      {
                return true;
                *pcount++;
      }

The maximum value of j can be size - 1. You know that, but I guess you just missed it.

Also in main(), place a return 0; before the end of main().

Welcome to the forum!

Yep, as std said you should get rid of the p_count pointer. Just count the attempts with a counter in main.


And you presumably mean to test j == 5 after the for loop (to see if the loop broke early or not, although there's a better way to do it...) So you'll have to declare j before the for loop so it'll be accessible after.


Another problem is that you're testing one beyond the end of the dice array. When j is size - 1 you test dice[j+1] which is beyond the end. You should only loop while j < size - 1.

And your high is 7 whereas it should be 6 (if these are regular dice).


And you'll probably want to print out the result too!


Note that it should give a yahtzee about 1 in every 1296 (6 to the 4th power) times, although any particular run can be quite different. On a 10000 trial run I got:
Avg: 1294.62 Min: 1 Max: 12324

Originally Posted by Javier Medina

Thanks so much guys! I fixed the for loop and removed the pointer for a simple counter in main. I'm still getting the hang of c++ as you can see hehe. I hope one day I can help new users in the forums like you guys

When I joined the forum, in 2010, I started programming. In 2010 I got chosen to participate in my CS degree (I am still undergraduate, since the course is one of 4 years). So, what you hope for, is not far from your reach I guess.