Classes and .h files

[jocdrew21]

Here is Main

#include <iostream>
#include <string>
#include "warrents.h"

using namespace std;

class addressBook {
    
public:
    explicit addressBook(string streetaddy, string phoneNumber)
    : street(streetaddy), phone (phoneNumber)
     
    {
    
    }
    
    void Address(string streetAddy)
    {
        street = streetAddy;
    }
    
    void PhoneNum(string phoneNumber)
    {
        phone = phoneNumber;
    }
    string getPhoneNum() const
    {
        return phone;
    }
    string getAddress() const
    {
        return street;
    }
  
private:
    string street;
    string phone;
};



int main(int argc, const char * argv[])
{
    addressBook address1("New York Way", "555-555-5554");
    addressBook address2("New Jersey Bld","678-979-9999");
    
    cout << "The first address is:"<<address1.getAddress()<<"\n "<< address1.getPhoneNum()<<endl;
     cout << "The second address is:"<<address2.getAddress()<<"\n "<< address2.getPhoneNum()<<endl;
    
    warrents recordChecker1("Boy are are good" "Girls are bad");
    warrents recordChecker2("Girls are good" "Boys are bad");
    
    cout << "The header file 1 says:"<<recordChecker1.getRecordBoy()<<endl;
    cout << "The header file 2 says:"<<recordChecker2.getRecordGirl()<<endl;
    
    return 0;
}

Here is the header file

//
//  warrents.h

#ifndef Classes_project_warrents_h
#define Classes_project_warrents_h

class warrents {
    
public:
    explicit checkRecord::checkRecord std::string (badBoy), std::string (badGirl)
    : boy (badBoy),girl (badGirl)
    {
    
    }
    void recordBoy()
    {
        boy = badBoy;
    }
    void recordGirl()
    {
        girl= badGirl;
    }
    std::string getRecordBoy()
    {
        return girl;
    }
    std::string getRecordGirl()
    {
        return boy;
    }
    
private:
    std::string boy;
    std::string girl;
};


#endif

[jocdrew21]

They are not talking... I am trying to hide the files and practice good programming by not reveling the whole code. Granted this is very basic but once I can get this to work I'll step it up a little.

[King Mir]

Your addressBook class is correct (on first inspection), but your warrents class, which looks like it's supposed to be identical in function, isn't written the same way.

As for the two not talking, that's likely a problem with your IDE settings. IDE's can sometimes compile a single file, but generally they compile projects. You want all files related to your program to be in the same project.

[std10093]

You could have a main and for every class a .h and a .cpp, where the first would hold the declarations, etc. and the last one, the implementation of the class (definitions of functions).

[jocdrew21]

MAIN

#include <iostream>
#include <string>
#include "checkFile.h"
#include "check.cpp"

using namespace std;

int main(int argc, const char * argv[])
{
    addressBook address1("New York Way", "555-555-5554");
    addressBook address2("New Jersey Bld","678-979-9999");
    
    std::cout << "The first address is:"<<address1.getAddress()<<"\n"<< address1.getPhoneNum()<<std::endl;
    std::cout << "The second address is:"<<address2.getAddress()<<"\n"<< address2.getPhoneNum()<<std::endl; 

    return 0;
}

.cpp file

#include <iostream>
#include <string>
#include "checkfile.h"

explicit addressBook::addressBook(string streetaddy, sting phoneNumber)
{
    street=streetaddy;
    phone=phoneNumber;
}
void addressBook::Address(std::string streetAddy)
{
    street = streetAddy;
}

void addressBook::PhoneNum(std::string phoneNumber)
{
    phone = phoneNumber;
}
string addressBook::getPhoneNum() const
{
    return phone;
}
std::string addressBook::getAddress() const
{
    return street;
}

.h file

//checkFile.h

#ifndef Classes_project_checkFile_h
#define Classes_project_checkFile_h
#include <iostream>
#include <string>
#include "checkfile.h"

class  addressBook{
    
public:
    explicit addressBook(std::string streetaddy, std::string phoneNumber)
    : street(streetaddy), phone (phoneNumber);
    
    void Address(std::string streetAddy)
    {
        street = streetAddy;
    }
    
    void PhoneNum(std::string phoneNumber)
    {
        phone = phoneNumber;
    }
    std::string getPhoneNum() const
    {
        return phone;
    }
    std::string getAddress() const
    {
        return street;
    }
    
private:
    std::string street;
    std::string phone;
};

#endif

Errors:
line 13 on checkFile.h Expected { or ','
line 6 .cpp file Expected ';' after top level declatator

If I fix these error a lot more show up. This is frustrating!!!

[vart]

you need to remove everything on line 13 except ; and move what is removed to the cpp where the constructor body is

[jocdrew21]

 
#include <iostream>
#include <string>
#include "checkfile.h"

explicit addressBook::addressBook(string streetaddy, sting phoneNumber)
:street(streetaddy), phone (phoneNumber)

{
    street=streetaddy;
    phone=phoneNumber;
}
void addressBook::Address(std::string streetAddy)
{
    street = streetAddy;
}

void addressBook::PhoneNum(std::string phoneNumber)
{
    phone = phoneNumber;
}
string addressBook::getPhoneNum() const
{
    return phone;
}
std::string addressBook::getAddress() const
{
    return street;
}

now the only error is on 6 and 7.

line 6 addressBook cannot be name of a variable or data member
line 7 ; after top level declarator

[Elysia]

Remove the explicit keyword from the source file.
You don't need to initialize and assign. Remove the assignment in the constructor body.
Don't include .cpp files. Compile separately and link. If you're using an IDE, create a new project and make sure both .cpp files are in it and build it.

[jocdrew21]

I do not understand....

[Elysia]

I do not understand what you do not understand. Be more specific.

[jocdrew21]

Remove the explicit keyword from the source file. (So I remove explicit, got it and did it)

You don't need to initialize and assign. Remove the assignment in the constructor body. (LOST)

Don't include .cpp files. Compile separately and link. If you're using an IDE, create a new project and make sure both .cpp files are in it and build it. (So remove my .cpp file? My book said it was safe programing practice?)

This just started C++, I got excited at first when I seen it was just like C but was soon let down. I am trying not to just write a program and move on but really understand what is going on. I sadly don't.

[Elysia]

This just started C++, I got excited at first when I seen it was just like C but was soon let down. I am trying not to just write a program and move on but really understand what is going on. I sadly don't.

That's okay. This is how it is in the beginning for everyone. I can elaborate.

You don't need to initialize and assign. Remove the assignment in the constructor body. (LOST)

addressBook::addressBook(string streetaddy, sting phoneNumber)
:street(streetaddy), phone (phoneNumber) // <--- Here you initialize your variables
{
    // Here you assign your variables
    street=streetaddy;
    phone=phoneNumber;
}

You be familiar with initialize vs assign. Basically, if you assign on the row where you declare, you initialize. You can also initialize using the initializer list (as you've done).
But what I meant is that your code is essentially the same as

std::string a = "a", b = "b";
a = "a";
b = "b";

You already initialize street and phone, so there is no need to assign them later as in this example.

Don't include .cpp files. Compile separately and link. If you're using an IDE, create a new project and make sure both .cpp files are in it and build it. (So remove my .cpp file? My book said it was safe programing practice?)

That depends on what you mean by "remove". If you mean remove the #include "check.cpp", then yes. Otherwise, no.
You should know that in C and C++, a program can consist of multiple files (called translation units). To make a program, you basically do my_compiler a.cpp b.cpp -o my_program.exe or the like. Note that I pass all .cpp files to the compiler. You should not include .cpp files from another .cpp file or header.

[jocdrew21]

Thank you very much. I still had issues so I thought I would try something else. Who what of thought it gave me more issues. I post the question in a new thread. I'll figure this out. You were a big help thank you very much.