What's the mistake i'v did in this?

**karthikslegend** · 06-25-2013

Code:

#include<iostream.h>
#include<stdio.h>
#include<conio.h>
int i,j;
int func1(int x,int y,int z);
int func2(int x,int y);
void main()
{
    clrscr();
    struct
    {
        int a;
        int b;
    }s1[3][3],s2[3][3],s3[3][3],s4[3][3];
    for(int i=0;i<=3;i++)
    {
        for(int j=0;j<=3;j++)
        {
            cin>>s1[i][j].a;
        }
    }
    for(i=0;i<=3;i++)
    {
        for(int j=0;j<=3;j++)
        {
            cin>>s1[i][j].b;
        }
    }
    for(i=0;i<=3;i++)
    {
        for(int j=0;j<=3;j++)
        {
        s1[i][j]=s2[i][j];
        }
    }
    for(i=0;i<=3;i++)
    {
        for(int j=0;j<=3;j++)
        {
            cout<<func1(s2[i][j].a,s2[i][j].b,s3[i][j].a);
        }
    }
getch();
}
int func1(int x[3][3],int y[3][3],int z[3][3])
{
    for(i=0;i<=3;i++)
    {
        for(j=0;j<=3;j++)
        {
            z[i][j]=x[i][j]+y[i][j];
        }
    }
    return z[i][j];
}
//int func2(int x,int y)
//{
  //    return x*y;
//}

**Elysia** · 06-25-2013

void main should be int main.
Arrays indexes go from 0 to size - 1. You have buffer overruns.
You are overwriting the same arrays multiple times.
You are trying to return a single index from func1 instead of the entire array (which can't be done anyway).
Your i and j are global variables (they should be local).
iostream.h should be iostream.
stdio.h should be cstdio. Do you even need it? I don't think so.
conio.h is non-standard and should be avoided. Use std::cin.get() instead of getch().
Well, that's a start anyway. You could make the code a little prettier, too.

**karthikslegend** · 06-25-2013

Thank you Elysia.. But I can't get you bcoz I'm a begginer, will u help me editing this program..

**laserlight** · 06-25-2013

What do you have trouble understanding in Elysia's statements?

**karthikslegend** · 06-25-2013

My compiler only runs the program if I include iostream.h and stdio.h, and what's that array index go from 0 to -1, I can't get that. But its showing a linker error.

**karthikslegend** · 06-25-2013

And i'v to call the function func1, so i have to declare main as void only, how can I use int there.

**karthikslegend** · 06-25-2013

And I'm a begginer too, so dont get annoyed with my questions.

**Elysia** · 06-25-2013

The first step is to get a modern IDE/compiler. Here is a list: http://cpwiki.sf.net/IDE
Code::Blocks is a very good IDE if you download it together with gcc (there's a link on their homepage with that bundle).

**karthikslegend** · 06-25-2013

Okay... Thank you.

**karthikslegend** · 06-25-2013

Linker Error: Undefined symbol func1(int,int,int) in module MYSAMP.CPP

This was the error I got

**Elysia** · 06-25-2013

Linker error results when you told the compiler a function exists but in reality it does not. Case in point, from your code:

Code:

int func1(int x,int y,int z);
void func1(int x,int y,int z)
{
	// Blah
}

This will result in a linker error if you try to call func1 from a function before the "void func1" (the definition) is seen by the compiler (ie, the code for it is above it). The reason is that the compiler thinks the return type is int, but later when the linker tries to put the program together, it can't find such a function.
If you don't understand this, then review how the compilation process works might help.

**karthikslegend** · 06-25-2013

Ya, I got your point.

**karthikslegend** · 06-25-2013

Thank you Elysia.

**Salem** · 06-25-2013

For reference -> What's the mistake i'v did in this? - Dev Shed

Understand that people hate wasting their time repeating what has already been said to you elsewhere.

Thread: What's the mistake i'v did in this?

Thread Tools

Search Thread

Display

What's the mistake i'v did in this?

Similar Threads

what is my mistake

mistake of using awk

What is my mistake ?

Tags for this Thread