Thread: Connect 4 game

Originally Posted by Aeoskype

Could you just write that checkwin function for me? Only for horizontal or vertical win.

Ah ha, when the "can you do it for me" finally comes out, we know it's a case of trying to get us to do your homework. If this were just for learning, you would get your mind stuck into solving the problem and manage to write at least something for it.

Flowchart - Wikipedia, the free encyclopedia
Regardless of homework or not, we do not usually help people solve their problems by fixing it for them. We tend to give them a nudge in the right direction, so to speak.

It's better if you just begin with that flowchart instead. You will see how easy it is.

Yes!!! Finally finished my checkwin function:

Code:

int checkwin(){
    for(int i=0; i<4; i++) // check for horizontal
    {
        for(int j=0; j<6; j++)
        {
            if(place[j][i] == cPlayerMark && place[j][i+1] == cPlayerMark && place[j][i+2] == cPlayerMark && place[j][i+3] == cPlayerMark)
            {
                    return 1;
            }
        }


    }


    for(int i=0; i<4; i++) // check for vertical
    {
        for(int j=0; j<3; j++)
        {
            if(place[j][i] == cPlayerMark && place[j+1][i] == cPlayerMark && place[j+2][i] == cPlayerMark && place[j+3][i] == cPlayerMark)
            {
                return 1;
            }
        }
    }


    for(int i=0; i<4; i++) // check for diagonal right to left
    {
        for(int j=0; j<6; j++)
        {
            if(place[j][i] == cPlayerMark && place[j+1][i+1] == cPlayerMark && place[j+2][i+2] == cPlayerMark && place[j+3][i+3] == cPlayerMark)
            {
                return 1;
            }
        }
    }


    for(int i=0; i<4; i++) // check for diagonal left to right
    {
        for(int j=0; j<6; j++)
        {
            if(place[j][i] == cPlayerMark && place[j+1][i-1] == cPlayerMark && place[j+2][i-2] == cPlayerMark && place[j+3][i-3] == cPlayerMark)
            {
                return 1;
            }
        }
    }
}

Works perfectly. Thanks to all who helped me!

EDITED: Not perfectly.

Originally Posted by Aeoskype

I think that i should change something here:
should i change column into a variable? And is it possible to change row pos0,pos1,pos2... into one variable?

You should change to using an array for posN, and then this code will be 1/7th of the length.

Originally Posted by Aeoskype

Yes!!! Finally finished my checkwin function:

Code:

int checkwin(){
    for(int i=0; i<4; i++) // check for horizontal
    {
        for(int j=0; j<6; j++)
        {
            if(place[j][i] == cPlayerMark && place[j][i+1] == cPlayerMark && place[j][i+2] == cPlayerMark && place[j][i+3] == cPlayerMark)
            {
                    return 1;
            }
        }


    }


    for(int i=0; i<4; i++) // check for vertical
    {
        for(int j=0; j<3; j++)
        {
            if(place[j][i] == cPlayerMark && place[j+1][i] == cPlayerMark && place[j+2][i] == cPlayerMark && place[j+3][i] == cPlayerMark)
            {
                return 1;
            }
        }
    }


    for(int i=0; i<4; i++) // check for diagonal right to left
    {
        for(int j=0; j<6; j++)
        {
            if(place[j][i] == cPlayerMark && place[j+1][i+1] == cPlayerMark && place[j+2][i+2] == cPlayerMark && place[j+3][i+3] == cPlayerMark)
            {
                return 1;
            }
        }
    }


    for(int i=0; i<4; i++) // check for diagonal left to right
    {
        for(int j=0; j<6; j++)
        {
            if(place[j][i] == cPlayerMark && place[j+1][i-1] == cPlayerMark && place[j+2][i-2] == cPlayerMark && place[j+3][i-3] == cPlayerMark)
            {
                return 1;
            }
        }
    }
}

Works perfectly. Thanks to all who helped me!

EDITED: Not perfectly.

Yes not perfectly alright.
If you came up with that on your own then well done, I'm glad you stuck in there and thought it through. Getting there on your own is always more satisfying.
The problem remaining is that you have buffer overruns and buffer underruns. These can be corrected for by adjusting the bounds of all of the for-loops.
E.g. if you loop contains [i-1]. Then start i at one, not zero.
You've already corrected line 18 for this, but you have more to go.