Thread: class

If someone has the time can you look at this and let me know what I am missing...I am not sure if my inspector functions are ok and what about the private area???? should there be functions down there also...HELP =)

#include <iostream>
#include <string>
using namespace std;

class StudentAccount
{
public:
// constructor that initializes the data members

StudentAccount(string ID, string name, double init);

// Mutator functions
void setStudentID(string ID);
void setStudentName(string name);
void setBalance(double init);

// Inspector functions
string getStudentID()
{
return studentID;
}
string getStudentName()
{
return studentNAME;
}
double getBalance()
{
return balance;
}
// Facilitator functions
// Add amount to balance
void CreditAccount(double amount);

{ cout<< "Enter the amount to be added;"<< endl;
int amount=0;
float totalbalance=0;
cin>> amount;
amount + balance = totalbalance
}
// Subtract amount from balance. If there is not enough
// money in the account, display an error message and do not
// modify the balance.
void DebitAccount(double amount);
{ balance - amount = balance
if(balance > totalbalance)
{ cout << "There is not enough money in your account to debit that amount"<<endl;
}

// Display all values
void PrintAccount();

private:
string StudentID; // it in the form ###-##-####
string StudentName; // Student's first and last name
double balance; // account balance
};

First of all if you noticed there is no main, I am not supposed to compile it. I'm questioning on how to do something...this message board is to get help am I correct or are you all here to bash anyone that has a queston b/c the haven't programmed since they came out of the womb.....Not all of us are experts ya know..There is no need to be so mean=)

-The debit account function misses a }
-The inspector functions could (should?) be made inline. The compiler might do this for you, but you can newer be to sure. (If you put the definition of the function outside the class it will not be inlined by the compiler... In most cases)
-You should have a virtual destructor. This is for inheritance reasons.
-Missing default constructor. This is not neaded, but something I usually have anyway. The compiler migth create this for you, but then again: don't be to sure about it. You could do like this also, to have an default constructor, kind of thing:

Code:

StudentAccount(string ID = "default", string name = "default", double init = 0.0);

-Since I think the mutator functions doesn't do more than just setting the value, these should be inlined to.
-I would go for more OOP when I'm at it. Create a baseAccount class. Let Student account inherit from baseAccount. Then you could make an TeacherAccount the same way. without any extra work.

Code:

class BaseAccount
{...};

class StudentAccount: public BaseAccount
{...};

class TeacherAccount: public BaseAccount
{...};

thanks ninebit that helps a lot=)
I appreciate your assistance=)