Thread: number of columns and lines in my array

I don't understand why my code doesn't display an array of 6 lines and 6 columns as i wish.

My code displays an array with 10 columns and 3 lines.
Than you in advance for the help.


Here is my code :

Code:

void initArray(float largeArray[5][5])
{
    for (int x=0; x < 5; x++)
        {
        for (int y=0; y<5; y++)
            {
            largeArray[x][y] = 0;
            }
        }


}


float printOutArray(float largeArray[5][5])
{
    for (int x = 0; x < 5; x++)
        {
            for (int y = 0; y < 5; y++)
                {
                    cout << largeArray [x] [y]<<'\t';


                }


        }
return largeArray[5][5];
}

int main()
{
    float largeArray [5][5];
    initArray(largeArray);
    printOutArray(largeArray);
}

Sorry, I forgot to say hello, so Hi everybody !! Any help would be greatly appreciated even if i know it may be some classic beginner error

Originally Posted by Neo1

You never actually change the line, so it just prints all array members on a long line (seperated by tabs)

Ok i understand, however i'm changing the line when i do this :

Code:

   for (int x=0; x < 5; x++){

So could you tell me how to do correctly change the line because i can't see how to do

Also your print function returns the same array as it was passed, which seems odd, and you don't actually use this return value either. Why not just make it return void like the other function?

i'm doing this because in the function i will use just next to the function printOutArray i will need the array largeArray

Does anyone have a solution to change correctly the line?

i changed it, i put 6 everywhere i had 5 in order to have 6 lines and 6 columns, but the result is exactly the same.
i also tried to put an endl by typing this :

Code:

cout << largeArray [x] [y]<<'\t'<<endl;

but it doesn't work anymore because then i get only one column on my console

Could someone give me the solution to this problem? i just want to have an array of 6 lines and 6 columns as i wish but i can't do it

You are also accessing your array out of bounds with the following statement:

Code:

    return largeArray[5][5];

Arrays in C/C++ start at zero and stop at size - 1. So in this case the valid index values would be 0,1,2,3,4 but not 5.

Jim

i try to understand what you Neo1 are explaining me, so i do this :

Code:

#include <iostream>#include <iomanip>
#include <cstdlib>


using namespace std;


void initArray(float largeArray[6][6]){
    for (int x=0; x < 6; x++){
            for (int y=0; y<6; y++){
                  largeArray[x][y] = 0;
        }
    }


}


float printOutArray(float largeArray[6][6]){
    for (int x = 0; x < 6; x++){


            for (int y = 0; y < 6; y++){
                    cout << largeArray [x] [y]<<'\t';
                }
           cout << largeArray [x] [y]<<'\t';
        }
return largeArray[6][6];
}
int main()
{
    float largeArray [6][6];
    initArray(largeArray);
    printOutArray(largeArray);
}

But it doesn't work anymore. What did you mean by "print a new line at this point"? In my code above i added a new print at this point but i must have added the wrong thing.
Moreover, is my indentation better now?

Elysia, to answer your question, my code is not finished, i return it because i will use it later as i said

i try to understand what you Neo1 are explaining me, so i do this :

Code:

#include <iostream>
#include <iomanip>
#include <cstdlib>

using namespace std;


void initArray(float largeArray[6][6]){
    for (int x=0; x < 6; x++){
            for (int y=0; y<6; y++){
                  largeArray[x][y] = 0;
        }
    }


}


float printOutArray(float largeArray[6][6]){
    for (int x = 0; x < 6; x++){


            for (int y = 0; y < 6; y++){
                    cout << largeArray [x] [y]<<'\t';
                }
           cout << largeArray [x] [y]<<'\t';
        }
return largeArray[6][6];
}
int main()
{
    float largeArray [6][6];
    initArray(largeArray);
    printOutArray(largeArray);
}

But it doesn't work anymore. What did you mean by "print a new line at this point"? In my code above i added a new print at this point but i must have added the wrong thing. Moreover, is my indentation better now?