Thread: strcmp problem

don't use strcmp or char arrays. use std::string.

No I have to use a char array. It is required for it to be used.

Check test condition of for loops.
If that doesn't solve post how you're getting the input.

Originally Posted by DeadPlanet

Check test condition of for loops.
If that doesn't solve post how you're getting the input.

I will but I am fixing things and I made a bigger problem. :b But I will do that soon!

Okay so the code has changed a bit now

Code:

bool LessThanByName( const Passenger & passenger ) const
   {
      char last0[MAX_LENGTH + 1];
      char last1[MAX_LENGTH + 1];
      char first0[MAX_LENGTH + 1];
      char first1[MAX_LENGTH + 1];
      
      for(int i = 0; i < last[i]; i++)
      {
         last0[i] = last[i];
     }   
      for(int i = 0; i < passenger.last[i]; i++)
      { 
        last1[i] = passenger.last[i];
      }
      for(int i = 0; i < first[i]; i++)
      {   
         first0[i] = toupper(first[i]);
      }
      for(int i = 0; i < passenger.first[i]; i++)
      {   
         first1[i] = toupper(passenger.first[i]);
      }
      
      if(strcmp(last0, last1) == 0)
        {
         return (strcmp(first0, first1) < 0);
        }
      return (strcmp(last0, last1) < 0);
   }

This is for whoever is wondering where the input comes from

Code:

 
   void SortByName()
   {
      for(int i = 0; i < passengerCount; i++)
         for(int j = i + 1; j < passengerCount; j++)
         {
            if(list[i].LessThanByName(list[j]))
               Swap( i, j );
         }

Why does it crash when the last name is the same?

Hmmm. Okay I am going to check that.

your for loops make no sense.

can you please explain exactly why you are comparing the counter to the value stored in the array at that index?

I checked the names, the passenger count and I am ment to use strcmp. We are sorting by alphabetical order.
So the results I got were that the compiler only crashes when the names are the same no matter where they occur in the file.
The error is also saying I have an array that isn't initialized. Any suggestions?

Oh no the for loops are assigning values to last0/1 , first0/1. The reason I am using the stored value is so that it only puts in the number of characters in the array and no more than that.

you could start by not copying the arrays. there is absolutely no need to do that.

Its was a move that my partner wanted. Thinking about it now, I'll clean it up.

Elkvis....you sir are a wizard. That some how made it work!
Also thank you to everyone that helped out! It helps me a lot!