Thread: Sort and count frequency of array elements.

I need a help please.
I have to count the frequency of values in the array. I have this code:

[/code]

Code:

int main()
{
   int size;
   int val, count;
   int list[] = {3,4,3,2,4,5,7,4,7,8,4,4,3,2,4,7,8,5,4,3,3,3,4,5,5};
   size = sizeof(list)/sizeof(int);


   cout << "Our unsorted list is: ";
   print(list, size);
   cout << endl;


   sort(list, size);
   cout << "Our sorted list is: ";
   print(list, size);


   cout << setw(6) << "Value:" << setw(12) << "Frequnce" << endl;
   getFrequency (val, list, size, count);


   return 0;
}


void getFrequency (int val, int list[], int size, int &count)
{
  for (int v=0; v<size; v++)
  {
    val = list[v] ;
    int count = 0;
    for (int k=0;k<size;k++)
    {
      if(list[k]==val)
         count++ ;
    }
    cout << setw(3) << val << " " << setw(10) << count <<endl;
  }
}

The code works, but at the end it outputs like
2 2
2 2
3 6
3 6
3 6 etc.

I can't figure out the missing part of the code so that output is only 1 of each repeating value like
2 2
3 6
4 8 etc.

Thank you.
P.S. I can't use pointers or classes with this task

I want to point out that the prototype could be instead of this

Code:

void getFrequency (int val, int list[], int size, int &count)

this

Code:

void getFrequency (int list[], int size)

-Why?
-Because val and count are local variables and should live only inside the.Also with your implementation you declare new ones inside the body,so no use of the parameters val and count.

As for the algorithm ,the same values lie next to each other,so let's take for example this sorted list
2,2,3,3,3,3,3,3
your algorithm will go and check the first element (list[0]) and will compute its frequency and eventually print it.Good until here.Now the main loop starts again,and v is increased by one... (!)
So now we are going to check for element list[1]...which is the same as the first..we do not want that.We want the value of v to be increased by two,so let's have this main for

Code:

for (int v=0; v<size; v+=2)

or not?Of course not!If you continue the algorithm and you reach the 3s then you see it will print 3 6 more than once and less that what you posted?
-Why?
-Because you increase the v by two.We should increase it by the number of the counter,in order to do not same 2 again while val is 2,or 3 again while val is 3
Hope this helps

Originally Posted by laserlight

Basically, you need to map each distinct element of the array to its frequency. The generic easy way is to just use a std::map or std::unordered_map. In this case though, if the elements of the array are guaranteed to be within some small range, you could just use another array to store the mapping.

Thank you for your advise, but I cannot use Classes here. Requirement is to use basic arrays and functions.

It would be good for this given array, but I need a generic function, in case if I don't know if there will be repetitions or how many repetitions in the array.

Originally Posted by Nurlana

It would be good for this given array, but I need a generic function, in case if I don't know if there will be repetitions or how many repetitions in the array.

I agree and the idea i said before targets this case exactly!You need to increase v by the counter of frequencies.Do not forget to initialize the counter to zero every time you are about to enter the loop.
So

Code:

for (int v=0; v<size; v+=counter)

is what i am saying
Hope this helps

Originally Posted by iMalc

Well it was mentioned a day ago that you should sort the array first.
I recommend writing code to do that and post it here.

I have already sorted the list. The function call is already in the main.
As for function description, I didn't show it here, because it was working fine.

Code:

void sort(int list[], int size)
{
  for (int i= size; i>1; i-- )
  {
    for (int j = 1; j<i; j++)
    {
      if (list[j-1]> list[j])
      {
        swap (list[j-1], list[j]);
      }
    }
  }
}

Sorry, guys, I am really stuck. My brains will soon fry. the instructor said I need to use the following in the main:

Code:

cout << setw[6] << "Value" << setw(12) << "Frequency" << endl;
int v = list[0];
int freq = 0;
getFrequency (v, data, size, freq);
cout << v << "  " << freq;
for (val=0; val<size; val++)
  if (v!=val)
 { 
    v = val;
    getFrequency (v, list, size, freq);
    cout << v << "  " << freq;
 }

But I don't understand this code. It seems repeating same thing. Can you help?