too many for loops?

This is a discussion on too many for loops? within the C++ Programming forums, part of the General Programming Boards category; So I'm working on a "simple" sudoku solving program in C++ and i ended up having a 6-nested loop in ...

  1. #1
    Registered User
    Join Date
    Oct 2012
    Posts
    1

    too many for loops?

    So I'm working on a "simple" sudoku solving program in C++ and i ended up having a 6-nested loop in the array and I keep hitting a STATUS_ACCESS_VIOLATION. i'm wondering if i have too many loops and the program just crashes? ill explain the code as best I can if you would like me to, but its hopefully not too confusing...

    Code:
    for ( int c = 0; c < 9; c++ )
    {
        if ( !complete[c] )
        {
            for ( int r = 0; r < 9; r++ )
            {
                if ( board[r][c][0] == '_' )
                { //if the square is still undefined
                    length = strlen(board[r][c]); //find the length of the char array
                        
                    bool instring = false;
                    int index = 0;
                    
                    for ( int col = 0; col < 9; col++ )
                    {
                    for ( int ro = 0; ro < 9; ro++ )
                    {
                        if ( counter[ro][col] != '_' )
                        {
                            cout<<true;
                            //see if the char in counter is in the string
                            for ( int g = 1; g < length; g++ )
                            {
                            if ( board[r][c][g] == counter[ro][col] )
                                {
                                index = g;
                                while ( index < length )
                                {
                                    board[r][c][index] = board[r][c][index+1];
                                    index++;
                                }
                            }
                        }
                    }
                    }
                    }
                }
            }
        }
    }

  2. #2
    Registered User
    Join Date
    Jun 2005
    Posts
    6,284
    Nesting of loops doesn't cause access violations. The problem will be a logic error in the loops (eg falling off the end of an array, molesting a pointer, the rookie mistake of believing that a pointer is an array, forgetting to zero terminate strings). You need to check all array indices to make sure they are of arrays (not just pointers) and are in bounds.


    Generally, deeply nested loops are considered a bad idea, because they are harder to understand and therefore harder to get right. That doesn't mean errors are because of nesting loops: it means that you've made an error, and are having trouble finding it in your nested loop structure.

    It is often considered a better idea to put particular loops into functions that achieve some well-defined effect. Then name the functions so the name describes the effect. Then, instead of nested loops, have functions calling functions. If the inner functions are well named, the logic of the calling function (loop calling the inner function) is easier to understand, so problems are easier to localise to one function.

    The loops will still exist, but by putting each loop into its own function, each loop will be easier to understand. IF you have designed and named the functions in a way that aids comprehension.
    Last edited by grumpy; 10-06-2012 at 06:48 PM.
    Right 98% of the time, and don't care about the other 3%.

  3. #3
    SAMARAS std10093's Avatar
    Join Date
    Jan 2011
    Location
    Nice, France
    Posts
    2,681
    Agree with grumpy.Your code results STATUS_ACCESS_VIOLATION probably because of the arrays you have.In a line you go out of bounds ,that's my guess

  4. #4
    Registered User
    Join Date
    Aug 2010
    Location
    Poland
    Posts
    682
    When you post some code like this, always attach variable declarations so that we can know what the stuff means. If this is the actual code, correct your braces (3 in the same column), because they are confusing and probably not doing what you want.
    I never put signature, but I decided to make an exception.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. converting for loops to while loops
    By nabhatt in forum C Programming
    Replies: 3
    Last Post: 02-16-2012, 08:45 PM
  2. Replies: 3
    Last Post: 06-01-2011, 04:19 PM
  3. loops, menu loops
    By gloworm in forum C Programming
    Replies: 17
    Last Post: 04-12-2010, 07:59 PM
  4. Loops
    By Dt7 in forum C++ Programming
    Replies: 3
    Last Post: 10-23-2004, 06:11 PM
  5. While, For loops
    By DeepFyre in forum C++ Programming
    Replies: 3
    Last Post: 10-11-2004, 09:35 PM

Tags for this Thread


1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21