Thread: Basic String Iteration Help, Best Solution?

after cutting out the control string i will be incremented by the for loop. If you don't have any chars between control strings i will point to the char past the begin of the next control string.
simple fix

Code:

	for(uint i = 0; i < str.length(); i++){
		if(str.at(i) == '['){
			const uint eb = str.find_first_of(']');
			if(eb != max_int and eb > i){ //begin capture sequence
				executeControlCode(str.substr(i + 1, (eb - i) - 1));
				str.erase(i, (eb - i) + 1);
                                --i; // <<---
			}
		}
	}

why don't you use string::npos to check for not found ??

Kurt

Yeah, that worked, thanks.

Oops, I thought npos was private.

Also you should not assume that std::string.find_first_of() returns a uint. You should be using a size_t, which is what this function returns. A size_t is not necessarily the same as a unsigned int, it could be any unsigned type.

Jim

Not sure what you mean; size_t typedefs to unsigned int?

typically, size_t is a typedef (possibly built-in) to unsigned long, and is guaranteed to be at least sizeof(void*) bytes wide, because it must, by definition, be capable of holding on to the size of things in bytes.