Input / Output - How to Create File?

Hey, Currently I making a little program that takes: Clients name and then the tracking code for that client and saves it in a 'char array'

However, my following code is not producing a file:

Code:

#include <iostream>
#include <fstream>
#include <string.h>

using namespace std;


int main()
{
    ofstream firstClass;
    char cname[25];
    char trackno[14];
    char outFileName[256];
    int z;


    cout <<"Enter the client name: "; cin >> cname;


    cout <<"Okay, Thats saved..." << endl; 
    cout <<" " << endl;


    cout <<"Please now enter the tracking code: "; cin >> trackno;


    cout << "Set the output file name: "; cin.getline(outFileName,256);


    firstClass.open(outFileName);
    firstClass << trackno;
    firstClass.close();


    cin >> z;
    return 0;
}

I suggest that you:

• Declare variables near first use.
• Keep each statement on its own line.
• Tell us how exactly does your program not work. (What exactly do you mean by "not producing a file"? Any error messages? What is the input, expected output and actual output?)

This one of the problems when mixing numeric input and character input. When you retrieve the trackno variable you leave the end of line character in the input buffer which the cin.getline() retrieves as the input to it's variable, skipping any actual entry of the name. To fix the problem you need to retrieve that end of line character. Use either a cin.get() or cin.ignore() to retrieve the problem characters.

Also you should always place only one command per line.

Code:

cout <<"Please now enter the tracking code: "; cin >> trackno;  // This is a bad practice IMO.
// This is better.
cout <<"Please now enter the tracking code: ";
cin >> trackno;

This will make debugging much easier in the future and also be easier not to miss the input.

Jim

Here's the new code file

Code:

#include <iostream>#include <fstream>
#include <string.h>
 
using namespace std;
 
 
int main()
{
    ofstream firstClass;
 
    char cname[25]; // Char array that holds the client name, ie; Ian Bell;
    cout <<"Enter the client name: "; // Prompting user to enter client name
    cin >> cname; // Takes the name of the client
 
    cout <<"Okay, Thats saved..." << endl; // Displaying friendly message to aknowledge user that Client name was taken successfully
    cout <<" " << endl;
 
    char trackno[14];
    cout <<"Please now enter the tracking code: "; // Here it asks the user to enter the tracking code (Shipping code)
    cin >> trackno; // Takes the tracking code
 
    char outFileName; // Variable that stores the filename user wants
    cout << "Set the output file name: "; 
    outFileName=cin.get(); // 



    return 0;
}

@ laserlight

I am trying to basically create 'new file' that writes the client name in that file and the tracking code. What lines would I add after getting the filename from user.

Sorry Very Noob Programmer and Hell slow learner..

Where are you getting the file name from the user? The following only gets one character:

Code:

char outFileName; // Variable that stores the filename user wants
    cout << "Set the output file name: ";
    outFileName=cin.get(); //

Jim

Originally Posted by jimblumberg

Where are you getting the file name from the user? The following only gets one character:

Code:

char outFileName; // Variable that stores the filename user wants
    cout << "Set the output file name: ";
    outFileName=cin.get(); //

Jim

Hey, actually I was following what you said..

Is this legal:

Code:

char outFileName[10]; // Variable that stores the filename user wants   
cout << "Set the output file name: "; 
    outFileName[10]=cin.get(); //

It is giving following error but doesnt show any compile errors

Stack around the variable 'outFileName' was corrupted.

Hey, actually I was following what you said..

No, I said you need to retrieve and dispose of the end of line character before you try to retrieve your string. Not try to retrieve a string in a single character.

Is this legal:

I think the following answers that question, don't you?

It is giving following error

Go back to your original program and before you try to retrieve your string with getline() try placing a cin.get(). And also note that cin.get() gets a single character, not a string.

Jim

I strongly suggest you:
* Use std::string instead of char arrays.
* Use std::getline to read a line.
What you are doing in unsafe and can result in buffer overflows. Don't do it.