Need a little help with code

[Ryan500]

Hi , im making a police database but im stuck on this code..... When i enter a wrong password and username for my program it still says "you are logged in" how do i changed that to say exit the program

thanks.

if ((password == "ryan1234") || (username == "ryan"))
{
cout <<"You are logged on as :"<< "Ryan Burrows" << endl;
}
else 
{
cout <<"Please exit the program!" << endl;
}

[King Mir]

You want to use && instead of ||.

Also as a general practice, you should never store the password anywhere. Instead store a cryptographic hash of the password, and compare the stored hash to the hash of the input password.

[Ryan500]

i dont no how to lol im sort of new to this thing iv should of sed really

[Ryan500]

this is the code up to now.....

#include <iostream>
#include <string>
using namespace std;
int main ()
{
string username = "ryan";
string password = "ryan1234";
 
cout<<"Police Database Version 2.3\n" << endl;
cout<<"Enter Username :";
getline(cin, username);
cout << "Login Password :";
getline(cin, password);
 

if ((password == "ryan1234") && (username == "ryan"))
{
}
else
{
system("CLS");
cout<<"Police Database Version 2.3\n" << endl;
cout<<"Invalid username" << endl;
}
if ((password == "ryan1234") && (username == "ryan"))
{
}
else
{
cout <<"Invalid password" << endl;
}

if ((password == "ryan1234") && (username == "ryan"))
{
cout <<"You are logged on as :"<< "Ryan Burrows" << endl;
}
else 
{
cout <<"Please exit the program!" << endl;
}
 
                           
system("pause");    
}

[Ryan500]

thanks , could you try and sort my problem i have out i did what you said with the && and now when i enter and wrong username and a right password it says wrong username and password if you know what i mean

[King Mir]

I removed that post because it was a very week hash.

If you want to do something when only the user name or only the password is wrong, then you need to have an appropriate if statement with a condition that one of them is wrong.

[Ryan500]

could you please give me a clue how to do it

[King Mir]

For example:

if (password != "ryan1234")
  cout << "Invalid password" << endl;

[Ryan500]

thank so much it worked

[Elysia]

Please indent your code in the future.
I'd recommend you google "computer cryptography tutorial", too. Learning this is a must due for security purposes today.