A Question/problem with classes and sending a variable to an object

Hi there,

sorry if this is really stupid but I am trying as hard as I can to understand classes from a book. I have declared my class and put in the accessor functions and declared everything private/public as I have been told.

I want to write a program that keeps a employee record. It asks the user for the data and then prints it back out to confirm it has all worked and has been stored correctly.

I have cut down the code attached to just one peice of data (the employee number) and two accessor methods untill I get this right. The problem is that when I run the program it just flicks up the console screen and then it vanishes despite the system("PAUSE"); after return 0; (I know, I know it's bad and I proboly shouldn't use it).

Can anyone tell me what I'm doing wrong and how to fix it. Many thanks

Code:

#include <iostream>using namespace std;


class record
{
private:
        int p_number;
       
        
public:
       void setp_number(int number);
       
       int getp_number();
      
};
//accessor functions//
//1
void record::setp_number(int number)
{
     p_number = number;
}


//get1
int record::getp_number()
{
    return p_number;
}


int main()
{
    int number;
    
    record Clive;
    cout << "set employee number: ";
    cin >> number;
    
    
    cout << "Thanks! To confirm:...." << endl;
    cout << "Clive is number: " << Clive.getp_number();
    
    
    
    
    return 0;
    system("PAUSE");
}

I suggest you read up on what return does. (Hint: Move your system( "Pause"); line before the return 0; line).

oh crap I feel a bit silly now,

thanks antred for clearing that up with the system("PAUSE"). I did know about that just my tired mind

I'm lost on your comment on reading what return does but I'll do it. I put it in because it said to do so in my book.

Anyways thanks

Originally Posted by Draylath

I'm lost on your comment on reading what return does but I'll do it. I put it in because it said to do so in my book.

I figured you didn't know that the return statement basically terminates control flow in the current function, but apparently it was merely a brainfart so disregard my previous suggestion.

Actually I am seriously lost now. Seems I've cut one head off the hydra

no matter what I input to the p_number it always comes back at me as 2 not what I inputed

Where are you setting p_number to any value?

What is the purpose of your setp_number() function?

Jim

I'm trying to pass the value of int number in the main part of the program into setp_number so that it will set the user input number into Clive and then be retrieved with getp_number. In all my books this is done in the code of main itself i.e Cat Frisky(5) but I don't want to do this. I want to set the value of p_number by user input.

Thanks fro your reply by the way I think I might have seriously missed something

Please show the line where you assign a value to p_number, anywhere in your code. I see you using a variable named number, but no where do I actually see you assigning a value to your class variable p_number. Again I ask what is the purpose of your class member function setp_number()?

Jim

That'll be the problem then, thanks Jim. You're quite right. I haven't assigned it a value at all have I? Apologies for me getting you to point out the obvious. Thanks again I'll keep bashing away at it but this is the closest I've ever got with classes so it's going ok

That is what the function I keep asking about is for, maybe you want to try using it.

Jim

I think I am closer now but it is still not working. I'm getting compiler errors now. I've done the following:

Code:

int main(){
    int number;
    
    record Clive;
    cout << "set employee number: ";
    cin >> number;
    Clive.setp_number(int number);
    
    cout << "Thanks! To confirm:...." << endl;
    cout << "Clive is number: " << Clive.getp_number();

this gives me an error saying expected primary expression before int in Clive.Setp_number etc line

Code:

cout << "set employee number: ";
cin >> number;
Clive.setp_number(int number);

Lose the red part.

mmm, now it's back to saying 2 again regardless of input. sorry to keep on about this I just want to get this right

Post your current code.

Jim

Code:

#include <iostream>
using namespace std;


class record
{
private:
        int p_number;
       
        
public:
       void setp_number(int number);
       
       int getp_number();
      
};
//accessor functions//
//1
void record::setp_number(int number)
{
     number = p_number;
}


//get1
int record::getp_number()
{
    return p_number;
}


int main()
{
    int number;
    
    record Clive;
    cout << "set employee number: ";
    cin >> number;
    Clive.setp_number(number);
    
    cout << "Thanks! To confirm:...." << endl;
    cout << "Clive is number: " << Clive.getp_number();
    
    
    
     system("PAUSE");
    return 0;
   
}