Hopefully a quickie

Code:

#include <iostream>

using namespace std;

short heightfeet {};
short heightinches {};
short weightpounds {};
float bmi{};

int main()
{
    cout<<"Please enter your height in feet : ";
    cin>>heightfeet;

    cout<<"Now the extra inches : ";
    cin>>heightinches;

    cout<<"And finally your weight in pounds : ";
    cin>>weightpounds;

    bmi=(weightpounds/2.2)/  ((heightfeet*12+heightinches)* 0.0254))*((heightfeet*12+heightinches)* 0.0254);

    cout<<endl<<endl<<"Your BMI is : "<<bmi;

    cout<<endl<<endl<<endl<<"I thank you......"<<endl;

    cin.get ();
    cin.get ();

    return 0;
}

The above code works as exected and gives the correct result (I have checked it with a BMI calculator on the web).

My query is that my compiler gives an error warning as follows:
line 21 expected ';' before ')' token.

Can you please tell me why as it seems OK to me?

> The above code works as exected and gives the correct result (I have checked it with a BMI calculator on the web).

> My query is that my compiler gives an error warning as follows:
> line 21 expected ';' before ')' token.
These two statements are contradictory.
Until your code compiles WITHOUT errors, you haven't proved anything about your code.

Start by counting your ( and ) on line 21

Thanks Salem, I spent ages counting them and splitting them up and somehow got it to be right every time but have now found the error.

Sorry to have wasted your time.

Get an IDE if you don't use one or get a better one.
These kinds of problems should be picked up by the IDE even before compiling the code.

The root cause of the problem is trying to do too much on one line.
Instead break the calculation up into parts that are stored in temporary variables. That way you wont need half as many brackets.

Thanks for the helpful comments. I use Code::Blocks but that didn't show up any error with the brackets.
iMalc, thanks for that comment, maybe I was trying to be too clever!!!

Have you adjusted the warning levels of your compiler yet. Right click the project in the Management Window then select Build Options, the start clicking the various warning check boxes. You should have at least Wall and Wextra checked. I recommend you check all warning options that are applicable to the language you are using.


Jim