Append or strcpy segmentation fault

[Eramol]

hi there
I was wondering if someone could help me.
I'm writing a programme, where I have to return some char array or string.
The problem is, it works only for the first time.. see

class CliLogic{
    private:
        char orient, state, * name;
        std::string m_buf;
    public:
        CliLogic(){state = 0; m_buf.reserve(1024);}
        void CM( const char * mes);        

};

Name receives a pointer from another class, so it should be valid (and actually IS valid, tested..). But take next method CM

void CliLogic::CM(const char * mes){
        printf("Start\n");
        m_buf = ""
        m_buf.append(name);
        printf(".");
        m_buf.append(mes);
        printf(".");
        m_buf.append("\r\n");
        printf(".");
        printf("%s\n",m_buf.c_str());        
}

On the first run it goes like "Start\n...Name message\r\nStart\n segmentation fault". Valgrind says it touches memory on 0x0, but I didn't figure out the fault. The size of the string (or char array, tested on both) shouldn't be a problem. Name is not bigger than 512 bits and message isn't longer than 5 chars + "\r\n".

I have tried it with append and with strcpy (which was originally there), both resulting in segfaults.

[laserlight]

Name receives a pointer from another class, so it should be valid (and actually IS valid, tested..).

So, the CliLogic object does not own the string represented by the name member, right?

On the first run it goes like "Start\n...Name message\r\nStart\n segmentation fault". Valgrind says it touches memory on 0x0, but I didn't figure out the fault. The size of the string (or char array, tested on both) shouldn't be a problem. Name is not bigger than 512 bits and message isn't longer than 5 chars + "\r\n".

You should initialise name to be a null pointer in the constructor, then check that both name and mes are not null pointers.

It would be better if you posted the smallest and simplest compilable program that demonstrates the segmentation fault. The problem with claiming that something that is not shown "actually IS valid, tested" is that you may have made an oversight, e.g., your tests may show validity of the pointer in a context before it becomes invalid.

[Elysia]

>>m_buf.reserve(1024);
A string is not a buffer. There is no need to reserve storage.

>>printf("Start\n");
Don't use printf. Use std::cout.

>>m_buf.append(name);
Or you could just type
m_buf += name;

>> m_buf = ""
>> m_buf.append(name);
Or you could just do
m_buf = name;

[Elkvis]

A string is not a buffer. There is no need to reserve storage.

but if you know how much data you'll be putting in it, pre-allocating space can improve performance, especially if you don't append all the data at once. this can become very important if you're dealing with large amounts of data (several megabytes or more).