Declaring an object of class type. Giving errors, need help!

[Kristyy_mariee]

I'm new to writing classes.
This is the class file.

#include <iostream>
#include <string>

using namespace std;
class phones

{
 private:
string phone;
string cost;
int year;

public:
phones();
void setPhone (string p );
string getPhone();
void setCost (string c );
string getCost();
void setYear (int y );
int getYear();
void Displayinfo();

#include <"phones.h">
#include <iostream>
#include <string>

 phones::phones(){}


void phones::setPhone (string p )
{
phone=p;
}
string phones:: getphone()
{
return phone};

void phones::setCost (string c )
{
cost=c;
}
string phones:: getcost()
{
return cost};

void phones::setYear (int y )
{
year=y;
}
intphones:: getyear()
};

and this is the main cpp file.

//#include <iostream>
//#include <"phones.h">
#include <string>
using namespace std;
int main()
{
    string phone;
string cost;
int year;

phones object; //error here
object.setphone("samsung");
object.setcost("thousand");
object.setyear("2010");
return 0;
}

The error in the main file states that the object (phones object) is undeclared.

[jimblumberg]

You need to #include your include file.

Jim

[phantomotap]

//#include <"phones.h">

That's a comment.

Also, choose one (<) or the other (").

Soma

[Kristyy_mariee]

hmm i did that already to see if it wouldchange anything. still saying that the class phones is undeclared..

[Kristyy_mariee]

when i put eihter <> or "" it send the error up to that line saying no such file or directory

[Elysia]

Then you have misplaced your files. Put them all into a single directory, then use "" to include them.
Btw, indent your code properly, and stop using strings for everything. There are things known as integers, too. Use them.
And don't use "using" directives in header files.

[VirtualAce]

Also consider:

void phones::setPhone (const std::string & p)
{
    phone=p;
}

const std::string & phones::getphone() const 
{
    return phone;
} 

void phones::setCost (const std::string &c )
{
    cost = c;
}

const std::string & phones::getcost() const
{
    return cost;
}

Consistency is your best friend. If you are going to use caps in the second word of all your methods then do this for every method. You have some that are all lowercase and others that use camelCase. If you do what others have told you in this thread your code should be compiling and running.

Some basic style rules:

• Set your compiler to use spaces instead of TABs for tabs. A tab can be 2,4,8,16, or any number of spaces and is not constant across editors. Never use tabs.
• Indent first line after brace in a class declaration
• Indent all variables in public, protected, and private sections (and keep public, protected, and privates in the same place)
• Indent all conditional blocks of code after the starting brace.
• Indent after the opening brace of a method
• Ensure all opening and closing braces of methods, conditional blocks, classes, etc. line up. This makes the code easier to read especially in editors like MSVS that will snap to the opening brace from the closing brace and vice versa. (This is optional in conditionals if you elect to place the starting brace on the same line as the conditional, switch, class declaration, etc)
• Indent after the opening brace of a switch() statement and indent all sections of code in each switch case. Some also use braces in switch statements.
• Use spaces between operators. IE: int total=x+y+z; is harder to read than int total = x + y + z;

There are other styles as well but almost everyone adheres to these. I personally indent my public, protected, and private keywords in a class but MSVS insists on placing them in the same column as the opening brace of a class declaration. As well I always use braces for one line conditionals, switch cases, and anywhere I want to or need to create scope. Some people place spaces after every comma. Personally I always place opening braces for any section on their own line. I never use them at the end of a line.

You will find your own style but if you adhere to a few simple rules most people will never complain about minor differences.

[Elysia]

[*]Set your compiler to use spaces instead of TABs for tabs. A tab can be 2,4,8,16, or any number of spaces and is not constant across editors. Never use tabs.

I sincerely object! Never use spaces.

[CornedBee]

Please don't start a tabs vs spaces debate in this thread ...