Constructors and array of object in C++

Hello, im trying to create an application in C++. In the application i have the default constructor and another constructor with 3 arguments. The user is providing from the keyboard an integer that it will be used to create an array of objects using the non default constructor. Unfortunately i haven't been able to finish it till now, since im having issues with the creation of the array of objects that they will use the non default constructor. Any suggestions or help?

What have you done so far in code?

Code:

  
#include<iostream>
#include<cstring>
#include<cstdlib>
#include <sstream>

using namespace std;


class Station{
	
public:
	Station();
	Station(int c, char *ad, float a[]);	
	~Station();	
	
	
	void setAddress(char * addr){
		
		  char* a;
   a = (char *)(malloc(sizeof(addr+1)));
   strcpy(a,addr);
   this->address = a;
	}
	
	void setCode(int c){
	code=c;	
	}

char getAddress(){
return *address;
}

int  getCode(){
return code;
}


float getTotalAmount(){
float totalAmount=0;
	for(int i=0;i<4;i++){
	totalAmount+=amount[i];
	}
return totalAmount;
}

void print(){

cout<<"Code:"<<code<<endl;
cout<<"Address:"<<address<<endl;
cout<<"Total Amount:"<<getTotalAmount()<<endl;
cout<<endl;
}


private:
	int code;
	char *address;
	float amount[4];

};


Station::Station(){
		code= 1;
setAddress("NO ADDRESS GIVEN");
		amount[0] = 0.0;
		amount[1]= 0.0;
		amount[2]= 0.0;
		amount[3]= 0.0;
			
	}



	Station::Station(int c, char *ad, float a[]){
	
	if( (c>=1&& c<=10 ) ){
	code=c;
	address=ad;
	
	for(int i=0;i<4;i++){
	amount[i]=a[i];	
	}	
	
	}else{
	
	code= 1;

setAddress("NO ADDRESS GIVEN");
		amount[0] = 0.0;
		amount[1]= 0.0;
		amount[2]= 0.0;
		amount[3]= 0.0;
	}

		
	
	
	}	
	
	
	Station::~Station(){
					
	}



int main(){


	int size,code;
	char *addrr;
	addrr = (char *)(malloc(sizeof(addrr+1)));
	float mes[4];

do{	
	cout<<"size of array:";
	cin>>size;
	
	}while(size<=0 || size>=11);
	
	//	Station *stations= new Station[size];
//	Station** stations = new Station*[size];
Station stations[size];
	
		for(int i=0;i<size;i++){
		
	cout<<"code:";
	cin>>code;
		
	cout<<"address:";
	cin>>addrr;
	
	
	
	double amo=0;
	
	for(int k=0;k<4;k++){
	cout<<"values"<<k+1<<":";
	cin>>mes[k]; 

	
	
	}

	
}
/*
for(int q=0;q<size;q++){
stations[q].print();
}
*/

return 0;
}

thats what i have so far..
i want to initialize the array objects according to the values that i'll get from cin
thanx

Okay, so how does it not work?

Indent your code properly, e.g., your main function should look like:

Code:

int main() {
    int size, code;
    char *addrr;
    addrr = (char *)(malloc(sizeof(addrr+1)));
    float mes[4];

    do {
        cout << "size of array:";
        cin >> size;
    } while (size <= 0 || size >= 11);

    //  Station *stations= new Station[size];
    //  Station** stations = new Station*[size];
    Station stations[size];

    for(int i = 0; i < size; i++) {
        cout << "code:";
        cin >> code;

        cout << "address:";
        cin >> addrr;
        double amo = 0;

        for (int k = 0; k < 4; k++) {
            cout << "values" << k + 1 << ":";
            cin >> mes[k];
        }
    }

    /*
    for (int q = 0; q < size; q++){
        stations[q].print();
    }
    */

    return 0;
}

Next, stop using malloc. If you need to do such manual memory management, use new and delete or new[] and delete[] instead. If allowed, use std::string instead.

thank you for your answer, but i really dont get it!
how im going to initialize the array of objects using the values from the cin and the non default constructor?
as i create the array of objects now it is using the default constructor.

Patience. First clean up the code to make it readable and use proper C++ constructs, then we can talk about your problem.

I cant use string and i have already clean the code, can you please provide me an answer to my problem?

Originally Posted by kspen

i have already clean the code

Post it..

Originally Posted by kspen

thank you for your answer, but i really dont get it!
how im going to initialize the array of objects using the values from the cin and the non default constructor?
as i create the array of objects now it is using the default constructor.

Although technically possible, non-default constructors typically aren't used with arrays of objects. Consider using the default constructor followed by direct assignment of each element (eg: array[index] = value), an std::vector, or what have you.

If you see someone trying to change a tyre by using a hammer to remove the nuts from the wheel, the first step is not to tell them how to swing a hammer properly. The first step is to first show them the correct tool, and then move on to show them the correct method (e.g. losen the nuts a little before jacking the car up all the way).
This is all we are doing here. We're helping you fix the glaringly obvious problems so that we can then focus on the minor mistakes.

This is very wrong:

Code:

    char *addrr;
    addrr = (char *)(malloc(sizeof(addrr+1)));

You need to fix such things first by getting rid of the malloc and instead considering the use of new[]. Then consider throwing away the new[] and consider just using a fixed-sized array on the stack.