Searching in linked list problem!

Hi,
I wanted to search an element (char) in the list S, but everytime it said that 02x is not in S
How to declare char target in a manner way? i think its my mistake for this code.
Thanks.

Code:

struct Node;typedef Node* NodePtr;
typedef void* VoidPtr;
typedef char* Ptr;
typedef int* Pi;
struct Node
{
	VoidPtr data;
	NodePtr next;
};

Code:

bool Search(NodePtr& head, VoidPtr& target)	
{
	bool found = false;
	
	NodePtr here = head;   
	
	while (here != NULL && !found) 
	{
		if (here->next ==target)
			found =true;
		else
			here = here ->next;
			return found;
	}
	
	
}




void Search_Menu (NodePtr& head)
{
	VoidPtr target;
	cout <<setw(70)<<setfill('=')<<endl;
	PrintList(head);
	
	cout <<"\nWhich element?: ";
	cin >>target;
	
	if((Search(head, target)==true))
	{
		cout <<target<<" is in S ."<<endl;
	}
	else
	{
		cout <<target <<" is not in S."<<endl;
	}
}

Fix your indentation and you'll see at least one problem :

Code:

    while (here != NULL && !found)
    {
        if (here->next ==target)
            found =true;
        else
            here = here ->next;
        return found;
    }

Also, are you sure that you're supposed to be searching for the address a node is stored at rather than the data stored in it?

I moved return found out of the loop , but still got error for the line if (here->next ==target).

Because I declare target as VoidPointer as requirement , This is what I'm stucking...

You'll need to compare the data elemenet of each node to the target, not the next element. However you'll need to know what type was actually stored there in order to be able to compare them. Normally one doesn't use void pointers in C++. We use templates instead.
If you insist on using void pointers then your best option is to have the called provide a comparison function as an argument to the Search routine.

Code:

int compare(VoidPtr vp1, VoidPtr vp2){
	char i = *(static_cast <char*>(vp1));
	char j = *(static_cast <char*>(vp2));
	
	if (i==j)
		return 0;


	else if( i<j)
		return -1;
	else 
		return 1;	 	 	 
		
}
bool Search(NodePtr& head, VoidPtr target)
	
{
	
	bool found = false;
	
	NodePtr here = head;   
	
	while (here != NULL && !found) 
	{
		if (compare(here->data,target)==0)
			found =true;
		else
			here = here ->next;
			
	}
	
		return found;
}




void Search_Menu (NodePtr& head)
{
	VoidPtr target;
	cout <<setw(70)<<setfill('=')<<endl;
	PrintList(head);
	
	cout <<"\nWhich element?: ";
	cin >>*(static_cast <char*>(target));
	
	if(Search(head, target)==true)
	{
		cout <<*(static_cast <char*>(target))<<" is in S ."<<endl;
	}
	else
	{
		cout <<*(static_cast <char*>(target)) <<" is not in S."<<endl;
	}
}

I changed to comparison of void pointer ... but it still does not work ...Any advise? Thanks

cin >>*(static_cast <char*>(target));

What is this supposed to mean? If you want to read a string, you need a string to put the input into. Not some random place in memory that doesn't even belong to you.

Thanks I changed VoidPtr target to char terget , worked...

Ummm... please post your code. Your latest code.