Help on seaching element in array using poitner C++

Hi,


I have a array string such as a set

Code:

S= {W,P,A,Z}

I only manage to search the first element which is W , but not for others ( it will say not found if i search for P, for instance), here is my code for searching part:
whats wrong with my code?

Code:

cout <<"\nWhich element?: ";
						cin >>which;
						
						if((Search(&a[0], size, which)==true))
						{
							cout <<which<<" is in S ."<<endl;
						}
						else
						{
							cout <<which <<" is not in S."<<endl;
						}
						break;

Code:

bool Search(char *a, int size, char *which) // Search element 
{
	Ptr c =&which[0];
	Ptr b= &a[0];
	
	for (int i=0;i <size;i++)
	{
	
		if (b[i]==*c)
		{
				
			return true; // true if found
			
		}
			
		else
		{
			return false;
		 // not Found element.
		}
		
	}
	
	
}

Thanks

What is Ptr? which probably should not be a pointer.

&a[0] would be the first thing in an array of (char*)s which... doesn't exist? Stop using pointers. char* is already a pointer

Hi,
I changed a litte bit, but it doesnt work for me ...still only found the first element...

Code:

bool Search(char *a, int size, char *which) // Search element 
{
	
	Ptr b= a;
	int flag =0;
	for (int i=0;i <size;i++)
	{
	
		if (b[i]==toupper(*which))
		
		{
			flag =1;
				
			return true;
		}
			
			if(flag==1)
			{	 
		
			return true;
	
			}
			else
			{
			return false;
			}
	
	}
}

Indent your code properly, e.g.,

Code:

bool Search(char *a, int size, char *which) // Search element
{
    Ptr b = a;
    int flag = 0;
    for (int i = 0; i <size; i++)
    {
        if (b[i] == toupper(*which))
        {
            flag = 1;
            return true;
        }

        if (flag == 1)
        {
            return true;
        }
        else
        {
            return false;
        }
    }
}

Now, it is clear that your code is equivalent to:

Code:

bool Search(char *a, int size, char *which) // Search element
{
    Ptr b = a;
    for (int i = 0; i <size; i++)
    {
        if (b[i] == toupper(*which))
        {
            return true;
        }
        return false;
    }
}

Hence the loop only iterates once, at most.

Hi ,
I'm not sure how to proceed next . Can you enlighten me?

Thankss

You need to move that return false; outside of the loop.

Thanks, my mistake lol...