"Problem with friend function"

Hi All,

I am facing compilition error for following code:

Code:

---

Angle.h:
-------
#include <iostream>
using namespace std;

class Angle
{
      int deg;
      int min;
      double sec;           
public:
      friend istream & operator >> (istream &, Angle &);
      friend ostream & operator << (ostream &, Angle &);

};

Angle.cpp:
#include "iostream"
#include "Angle.h"
using namespace std;
istream & operator>> (istream &in, Angle &A)
{
            in>>A.deg;
        in>>A.min;
        in>>A.sec;       
}

ostream & operator<< (ostream &out, Angle &A)
{
     
          out<<"Deg: "<<A.deg<<endl;
              out<<"Min: "<<A.min<<endl;
                  out<<"Sec: "<<A.sec<<endl;
}

int main()
{
        Angle A;
        cin>>A;
        cout<<A;
    return 0;

}

---

I am getting following errors, even though i am accessing private variables via friend function:

c:\dev-cpp\examples\angle.cpp(82) : error C2248: 'deg' : cannot access private member declared in class 'Angle'
c:\dev-cpp\examples\angle.h(10) : see declaration of 'deg'
c:\dev-cpp\examples\angle.cpp(83) : error C2248: 'min' : cannot access private member declared in class 'Angle'
c:\dev-cpp\examples\angle.h(11) : see declaration of 'min'
c:\dev-cpp\examples\angle.cpp(84) : error C2248: 'sec' : cannot access private member declared in class 'Angle'
c:\dev-cpp\examples\angle.h(12) : see declaration of 'sec'
c:\dev-cpp\examples\angle.cpp(90) : error C2248: 'deg' : cannot access private member declared in class 'Angle'
c:\dev-cpp\examples\angle.h(10) : see declaration of 'deg'
c:\dev-cpp\examples\angle.cpp(91) : error C2248: 'min' : cannot access private member declared in class 'Angle'
c:\dev-cpp\examples\angle.h(11) : see declaration of 'min'
c:\dev-cpp\examples\angle.cpp(92) : error C2248: 'sec' : cannot access private member declared in class 'Angle'
c:\dev-cpp\examples\angle.h(12) : see declaration of 'sec'

Regards,
Siddu

Avoid putting using namespace statments in your headers. They are fine in code files but not in headers. Explicitly qualify any necessary objects with std:: where necessary. Also, implement header guards. Your header file should look more like:

Code:

---

#ifndef ANGLE_H
#define ANGLE_H

#include <iostream>
 
class Angle
{
      int deg;
      int min;
      double sec;           
public:
      friend std::istream & operator >> (std::istream &, Angle &);
      friend std::ostream & operator << (std::ostream &, const Angle &);
 
};

#endif

---

Your overloaded operator<</operator>> functions need to return the stream object that has been passed in:

Code:

---

istream& operator>> (istream &in, Angle &A)
{
    in>>A.deg;
    in>>A.min;
    in>>A.sec;
    return in;
}
 
ostream & operator<< (ostream &out, const Angle &A)
{
    out<<"Deg: "<<A.deg<<endl;
    out<<"Min: "<<A.min<<endl;
    out<<"Sec: "<<A.sec<<endl;
    return out;
}

---

Quote:

---

Originally Posted by Shidlingayya

Code:

---

Angle.h:
-------
#include <iostream>
using namespace std;

---

---

you really should not have using declarations in header files. it pollutes the global namespace in places where you might not want it.