Binary post #xxx

Ok so, having looked at the numerous other posts on problems with binary files (reading/writing) I cannot see what I am doing wrong.

Code:

void CFile::SaveFile()
{
    std::ofstream fout;
    fout.open(filename.c_str(), std::ios::out | std::ios::binary);

    if( fout.is_open() )
    {
        for(int loop = 0; loop < MAX_DATA_SIZE; loop++)
            fout.write((char *)&DataList[loop], sizeof(CHighScore));

        fout.close();
    }
}

This part seemingly works just fine, MAX_DATA_SIZE is 10, CHighScore is 8 bytes, and I end up with a saved file of 80 bytes.

But when I go to read it in, it opens the file, then shuts right down.
I've also tried taking out the loop and just reading a single instance from the file, so I know I am just not understanding/missing something.

Code:

void CFile::LoadFile()
{
    std::ifstream fin;
    fin.open(filename.c_str(), std::ios::in | std::ios::binary);

    if( fin.is_open() )
    {
        for(int loop = 0; loop < MAX_DATA_SIZE; loop++)
        {
            CHighScore temp;
            fin.read((char *)&temp, sizeof(CHighScore));
            DataList.push_back(temp);
        }

        fin.close();
    }
    else
        DefaultBuild();
}

What is CHighScore? 8 bytes seems small for the size of a class.

Originally Posted by rags_to_riches

What is CHighScore? 8 bytes seems small for the size of a class.

It just holds a player's initials and score, a string and an int. Like I say, it seems to write the file just fine, and I know that it opens the file for reading (I oft use the window caption for debugging messages for myself). When it tries to read in data it closes down the window.

Originally Posted by Incantrix

It just holds a player's initials and score, a string and an int.

Post the class definition. This is important because if by "string" you mean std::string, then what you are doing is wrong, because writing the bytes of a std::string to file does not work to store the contents of the std::string.

Well, even if it were writing incorrect information, it should still be able to read in the 8 bytes, even if they gave nonsense, correct?

Originally Posted by Incantrix

Well, even if it were writing incorrect information, it should still be able to read in the 8 bytes, even if they gave nonsense, correct?

True, but then this would result in undefined behaviour:

Code:

DataList.push_back(temp);

so all bets are off, unless you can prove that it is this statement that causes the "shuts right down" thing to happen, on the first iteration of the loop:

Code:

fin.read((char *)&temp, sizeof(CHighScore));

Why on earth are you resisting showing us the class definition?