Keep console open

In the following listing I have used cin.get() to keep the console window open when I run the .exe file - it has worked before for me but in this program it doesn't - the console shuts immediately after outputting the list - I just know this is going to be something obvious so sorry in advance!!

Code:

#include <algorithm>
#include <iostream>
#include <istream>
#include <ostream>
#include <vector>


using namespace std;

int main()
{
  vector<int> data;     // initialized to be empty
  int x(0);

  // Read integers one at a time.
  while (cin >> x)
    // Store each integer in the vector.
    data.push_back(x);

  // Sort the vector.
  sort(data.begin(), data.end());

  // Print the vector, one number per line.
  for (vector<int>::size_type i(0); i != data.size(); i = i + 1)
  {
      cout << data.at(i) << '\n';
  }

cin.get();

Try using cin.ignore() prior to that cin.get() so as to discard leftover characters from the input buffer (e.g., the enter you used on that last line to trigger EOF). Note that cin.ignore takes arguments such that you can ignore more than one character.

That is because your program has trailing newline (enter) characters. Read How to keep my console window open-FAQ

The cin.ignore() didn't make any difference I am afraid.

But

printf ( "Press any key to continue . . ." );
getch();

return 0;

did work.

It seems a bit much to have to include 2 more libraries to use printf and getch just to keep that window open; there must be an easier way - or is all C++ so convoluted?

Originally Posted by JayCee++

The cin.ignore() didn't make any difference I am afraid.

Since you had to trigger EOF to get the output in the first place, the stream should no longer be in the good state. Therefore, use cin.clear() prior to cin.ignore() to clear the error state.

Thanks that works, so if I put
cin.clear();cin.ignore();cin.get();
as the last line of my little progs the console window will always stay open till I press a key!

Not necessarily, because there may be more characters left on the input buffer.

The solution I recommend is to simply run your command line program from a command prompt window

Cprogramming.com FAQ > Stop my Windows Console from disappearing everytime I run my program?
SourceForge.net: Pause console - cpwiki

Originally Posted by AndrewHunter

That is because your program has trailing newline (enter) characters. Read How to keep my console window open-FAQ

Originally Posted by Elysia

Cprogramming.com FAQ > Stop my Windows Console from disappearing everytime I run my program?
SourceForge.net: Pause console - cpwiki

Hmm...it appears we agree again.