switching value of variable?

I'm trying to ru this code however it's not working for me. I need to switch the value of "x" with the value of "y" if (x<y) however it's not working the way I wrote it. Does anyone have any suggestions?

Code:

{ 


    int x=0;
    int y=0;
    int temp=0;
    int remainder=0;

    // read in the two integers

    cout << endl ;
     cout << "Enter the first number (integer) : " ; 
    cin >> x ;
     cout << "Enter the second number (integer) : " ; 
    cin >> y ;
 
    //echo inputs
 
    cout << "Input numbers are: " << x << " , " << y << endl;

    if ( x < y) 

		
    
       { // exchange values of x and y 

		 temp=x;
		 x = y;
		 y==temp;
      

 }

So when you compile the code and you get an warning saying something like "line 35: statement has no effect" you should look a little closer at line 35:

Code:

y==temp;

If you're not getting that warning, now is a good time to take a little time-out and read up on how to use your compiler.

For starters, you have an "equal to" operator instead of an assignment operator in this block.

Code:

{ // exchange values of x and y 

		 temp=x;
		 x = y;
		 y==temp;
	}

When I try to simply put y=temp it doesn't work. No values switch at all. When it tires to compile it states that == has no effect however when it is there temp and x actually change values.

I am fairly new to C ++ and that is the error I am getting. I just want to know how to fix it.

Originally Posted by genesis531501

When I try to simply put y=temp it doesn't work. No values switch at all.

This statement is incorrect.

(ETA: Perhaps the confusion comes from the fact that the Euclidean algorithm does not care one whit whether the numbers start out in the right order, so you'll get the same answers as you got before even once you got the swap working.)

Have you tried sprinkling some "couts" through your code to see current values and where the program goes wrong? (You could run a debugger, too, but this might be easier to start with.)

maybe a beter question would be if anyone is familair with switching variable values using a temp variable?

Yes, we all are. What you have for swapping variables is correct (once you remove the extra equals sign). You should probably try telling us why you think it doesn't.

I run the program and I input two numbers. program stops and it says what the input numbers are. It should however give me the GCD for the two numbers. In the compiler it shows no values being swapped. for example when x and y should swap later in the program I have x%y however the compiler shows both of them at zero or intx, int y.

Code:

    if ( x < y) 
    { // exchange values of x and y 
        temp=x;
        x = y;
        y=temp;
     }
 
    cout << "x = " << x << " , y = " << y << endl;

Try this and tell us what you get.

Make sure you didn't move the line; the y = temp line needs to be last. Just put another copy of

Code:

cout << "Input numbers are: " << x << " , " << y << endl;

right after the swap and you'll see them change as appropriate.

Also at the end of your loop, you are supposed to have zero for the remainder; that's the point of the Euclidean algorithm. The GCD should be left in y.

I appreciate that they did switch. thank you, The GCD should be left in y however the end of my code say to out put the GCD. no GCD is out putted.

You edited out the loop bit. I'm guessing you're going one loop too far (i.e. checking the wrong value to be zero), but I don't remember for sure now what you had there.

Can you share the algorithm again?