Segmentation Error Help!

So I have an array, that works up to about int array_size = 410000; and then anything higher than that it says segmentation error. I want to be able to use array_size = 1470000; Help!!! (YES, it compiles fine.)

Here is where I use it:

Code:

int main ( int argc, char *argv[] )
{


  char *filename_hdr, *filename_ascii_dat,*filename_binary_dat, *filename_ascii_write, * pEnd;
  string line, line1, dum1[6], string_value;
  ifstream is; //this will use the lvis binary data 
  Header laurentides;
  int array_size = 410000;
  int lonpix [array_size], latpix[array_size], i = 0, length, end_data; 
  float  value[array_size];   
  long offset;
  double datastore[(array_size+1)][1]; 
  
   
 filename_hdr = argv[1];
 filename_ascii_dat = argv[2];
 filename_binary_dat = argv[3];
 filename_ascii_write = argv[4];

laurentides.getHdrFile(filename_hdr);

 end_data = array_size+ 1;
/*
.
.
.
.
.
.other lines of code not important...
.
.
.
.
.
*/

  ofstream asciiwrite(filename_ascii_write, ios::out);
  

 //while loop to extract data from .txt file and calculate pixel degrees
  while(i < end_data  && getline(datain, line1))
    {
	  
      istringstream datstream(line1, istringstream::in);
     
      datstream >> dum1[0] >> dum1[1] >> dum1[2] >> dum1[3] >> dum1[4] >> dum1[5] ;
      datastore[i][0] = strtod(dum1[0].c_str(), &pEnd); //lat 
      datastore[i][1] = strtod(dum1[1].c_str(), &pEnd); //long
	 

	 
      latpix[i] = (laurentides.lat-datastore[i][0])/(laurentides.x_pixsize);
      lonpix[i] = (datastore[i][1]- laurentides.lon)/(laurentides.y_pixsize );
	
	  

      //offset here calculates the  number of pixels that the data occupies in the actual binary file and points to it 
      offset = latpix[i]*laurentides.numsamples+lonpix[i];
      
      //here were getting the size of the data in memory
      offset = offset*sizeof(long); //float
      
      // cout<<"reading file at "<< offset <<endl;

      is.seekg (offset, ios::beg);   
      is.read ((char *) &value[i], sizeof(float)); //double
     
      //cout <<"THIS IS FSEEK VALUE: " <<  value[i] << endl;
        
      asciiwrite << dum1[0] << "     "
                 << dum1[1] << "     " 
		 << dum1[2] << "     " 
		 << dum1[3] << "     "  
		 << dum1[4] << "     " 
		 << dum1[5] << "     " 
		 << value[i] << endl;
    
       i++;
	
    }



  is.close();
  asciiwrite.close();
  return 0;

 

}

How about a long instead of an int ?

Code:

int array_size = 410000;

You should use a vector instead. Then you don't even have to specify the limit, you can just push_back more and more values as your program read in more and more data. A vector doesn't store the data on the stack which means it wont run into the stack size limit that you are running into.
If you cant use that, then you will need to use dynamic memory allocation through new and delete.

K, I tried turning it in to a long,using a vector, and allocating memory and nothing worked

What I dont understnd is why it works up until about 410,000 and then won't work after that and says "segmentation fault". I just don't get it.

It appears that you're defining your array size to be 410,000 - so when you go past this value, you're writing into memory that you don't own. Hence, a segmentation fault.

Yes, but I only posted that there as reference lol. I do actually change it to array_size= 1466861 in my code and that's when I get segmentation fault and I don't know whyyyyyyy.

Sorry, I misunderstood.

Code:

is.read ((char *) &value[i], sizeof(float)); //double

Can someone explain how the above is safe to an C programmer?
Using a float to store chars just seems wrong.

And, I missed the line of code opening "is"; does it default to something?

Tim S.

Hello Tim,

Yeah "is" came from a call to ifstream as "ifstream is;" and I used that to open a file of mine. As for the is.read, no idea. I jsut looked up the function to do what I needed it to do and it did it! So, at this point it's prob not the safest but i'm a novice so hopefully time will be a better teacher. For now, have to get this work done! ahhh.

Also, for my problem and anyone who looks at this, I was told that the limit to my array size could actually be the computer itself and something called its "stack memory."

Yes, I also suspect you're hitting the stack limit.
Using your example:

Code:

 int array_size = 410000;
  int lonpix [array_size], latpix[array_size], i = 0, length, end_data; 
  float  value[array_size];   
  long offset;
  double datastore[(array_size+1)][1];

With your example of 410000, you're trying to allocate 2870000 bytes, that's around 2.5MB, on the stack.

You said you'd tried allocating memory, how?
"new" in C++ and "malloc" in C are used to allocate memory on the heap. You should be able to use that:

Code:

  char *filename_hdr, *filename_ascii_dat,*filename_binary_dat, *filename_ascii_write, * pEnd;
  string line, line1, dum1[6], string_value;
  ifstream is; //this will use the lvis binary data 
  Header laurentides;
  int* lonpix = new int[array_size];
  int* latpix = new int[array_size];
  int i = 0, length, end_data; 
  float*  value = new float[array_size];    
  long offset;
  double (*datastore)[1] = new double[(array_size+1)][1];

However segmentation faults can be caused by any kind of access violation, so it might not be this. You can confirm by using a debugger or putting a "cout << "reached here" statement at the beginning of the function. If it's never reached (the segfault happens on function entry) then it's very likely the stack. If it's happening somewhere else, probably not the stack and maybe overrunning array bounds as suggested.

If you do use new, you have to accompany that with delete. Hence, it's better to use std::vector if you can.

Originally Posted by Blah937

I was told that the limit to my array size could actually be the computer itself and something called its "stack memory."

It's not a limit of the computer itself, it's a limit that your project settings is imposing. You can change this limit but that is generally the wrong solution, which is why you were given other solutions.

K, I tried turning it in to a long,using a vector, and allocating memory and nothing worked

That just means you don't know what you're doing. We cant see how you're messing up without seeing some code.