Thread: new way of doing it

  1. #1
    Registered User
    Join Date
    Jun 2011
    Posts
    3

    Question new way of doing it

    Code:
     deduction = 0;
          if(deductiontype.compare("Itemized") == 0)
           {
             while(1)
               {
              input>> deditem;
              if(deditem==0)
    
             break;
               deduction =deduction+ deditem;
                }
          }
    im trying to figure out if there a different way to put while(1)
    which equalls true but is there a different way without putting 1 in there

  2. #2
    Registered User
    Join Date
    May 2011
    Location
    Around 8.3 light-minutes from the Sun
    Posts
    1,949
    Code:
    do{ 
    	cin >> ded;
    	deduction+=ded;
    }while ( ded != 0);
    Quote Originally Posted by anduril462 View Post
    Now, please, for the love of all things good and holy, think about what you're doing! Don't just run around willy-nilly, coding like a drunk two-year-old....
    Quote Originally Posted by quzah View Post
    ..... Just don't be surprised when I say you aren't using standard C anymore, and as such,are off in your own little universe that I will completely disregard.
    Warning: Some or all of my posted code may be non-standard and as such should not be used and in no case looked at.

  3. #3
    C++ Witch laserlight's Avatar
    Join Date
    Oct 2003
    Location
    Singapore
    Posts
    28,413
    For starters, format your code properly, e.g.,
    Code:
    deduction = 0;
    if (deductiontype.compare("Itemized") == 0)
    {
        while (1)
        {
            input >> deditem;
            if (deditem == 0)
                break;
            deduction = deduction + deditem;
        }
    }
    Now, it is easy to see that you can simplify to:
    Code:
    deduction = 0;
    if (deductiontype.compare("Itemized") == 0)
    {
        while ((input >> deditem) && deditem != 0)
        {
            deduction += deditem;
        }
    }
    Incidentally, if you were just looking to replace the 1, then replace it with true, or you can use for (;;) instead.
    Quote Originally Posted by Bjarne Stroustrup (2000-10-14)
    I get maybe two dozen requests for help with some sort of programming or design problem every day. Most have more sense than to send me hundreds of lines of code. If they do, I ask them to find the smallest example that exhibits the problem and send me that. Mostly, they then find the error themselves. "Finding the smallest program that demonstrates the error" is a powerful debugging tool.
    Look up a C++ Reference and learn How To Ask Questions The Smart Way

Popular pages Recent additions subscribe to a feed