character arrays (basics, stuck on applying the tutorial)

I'm working my way through the C++ tutorials and I'm stuck on character arrays. Basically, I don't understand how a user can input a sentence into the program and then how to store that sentence in a variable, ready to be called in a cout<< line.

Here is a piece of code I'm trying to work on (to no avail). The problem here isn't identical but an answer to the previous question will probably help answer this one.

Code:

#include <iostream> //For cout

using namespace std;

int main()
{
int monstype;
char monsdescription[35];
cout <<"please choose the monster you wish to fight:\n1. Big hairy ugly thing\n2. Small and easy on the eyes\n3. Medium size, much the same as you!\n";
cin>> monstype;
if (monstype == 1){
monsdescription = "Big hairy ugly thing";
}
else if (monstype == 2){
monsdescription = "Small and easy on the eyes";
}
else{
monsdescription = "Medium size, much the same as you!";
}
cout <<"You have chosen "<< monstype <<", "<< monsdescription <<"";
cin.get();
}

Why doesn't

Code:

if (monstype == 1){
monsdescription = "Big hairy ugly thing";
}

work? The error line says:
incompatible types in assignment of 'const char [27]' to 'char [35]'

or

Code:

else{
monsdescription = "Medium size, much the same as you!";
}

with an error line :
invalid array assignment

Since you are using null terminated character arrays (C-string) you can not use the assignment operator (=) you need to include string.h and use strcpy().


Jim

> char monsdescription[35];
So include string, and do
std::string monsdescription;

Thanks for your comments but I'm still stuck...

I've tried using the strcpy but it's not working (it's the only operator that isn't in the example in the tutorial!). Here's my best attempt so far:

Code:

if (monstype == 1){
char strcpy (char monsdescription,"Big hairy ugly thing");
}

Meaning the overall code is now:

Code:

#include <iostream>
#include <cstring>

using namespace std;

int main()
{
int monstype;
char monsdescription[35];
cout <<"please choose the monster you wish to fight:\n1. Big hairy ugly thing\n2. Small and easy on the eyes\n3. Medium size, much the same as you!\n";
cin>> monstype;
if (monstype == 1){
char strcpy (char monsdescription,"Big hairy ugly thing");
}
else if (monstype == 2){
char strcpy (char monsdescription,"Small and easy on the eyes");
}
else{
char strcpy (char monsdescription,"Medium size, much the same as you!");
}
cout <<"You have chosen "<< monstype <<", "<< monsdescription <<"";
cin.get();
}

Ok, so you need to decide whether you are going to use C styles strings which are character arrays or C++ strings. My suggestion would be to stick with C++ strings for what you are doing. In that case you need to do:

Code:

#include <stdio.h>
#include <iostream>
#include <string>

...
int main() {

    string monsdescription;
...
    if (monstype == 1){
	monsdescription = "Big hairy ugly thing";
    }

And then your provided cout statement is fine.

That was much much simpler and easier to understand, thanks a lot!

No problem, also don't forget at the end of your main function you need to return(0) back to the OS.

Originally Posted by AndrewHunter

don't forget at the end of your main function you need to return(0) back to the OS.

This will happen automatically if control reaches the end of the global main function without encountering a return statement.

Originally Posted by laserlight

This will happen automatically if control reaches the end of the global main function without encountering a return statement.

Happy Canada Day Laser! So, my guess is then per the standard for C++ you do not need to have the statement included?

Yes, though of course you may choose to have it for consistency or style.

I see, thanks for the insight Laser.