A C++ Help System for loops

I wrote this a few days ago, and just made an account on here.

Tell me what you guys think :]
And if theres need for improvement, let me know.

--------------------->

Code:

---


#include <iostream>
using namespace std;

int main()
{
        char choice;
       
        for(;;) {
                do {
                        cout << "Help on:\n";
                        cout << " 1. if\n";
                        cout << " 2. switch\n";
                        cout << " 3. for\n";
                        cout << " 4. while\n";
                        cout << " 5. do-wjile\n";
                        cout << " 6. break\n";
                        cout << " 7. continue\n";
                        cout << " 8. goto\n";
                        cout << " Choose one (q to quit): ";

                        cin >> choice;
                        cout << "\n";

                        if(choice < '1' || choice > '8' && choice != 'q')
                                cout << "Incorrect selection, please try again.\n\n";
                       
                } while(choice < '1' || choice > '8' && choice != 'q');
               

                if(choice == 'q') break;

                cout << "\n\n";


                switch(choice)
                {
                        case '1':
                                cout << "The if:\n\n";
                                cout << "if(condition) statement;\n";
                                cout << "else statement;\n";
                                cout << "\n";
                                break;
                        case '2':
                                cout << "The switch:\n\n";
                                cout << "switch(expression) {\n";
                                cout << "        case constant: \n";
                                cout <<        "                statement sequence\n";
                                cout << "                break;\n";
                                cout << "}\n";
                                cout << "\n";
                                break;
                        case '3':
                                cout << "The for:\n\n";
                                cout << "for(init; condition; increment)";
                                cout << "        statement;\n";
                                cout << "\n";
                                break;
                        case '4':
                                cout << "The while:\n\n";
                                cout << "while(condition) statement;\n";
                                cout << "\n";
                                break;
                        case '5':
                                cout << "The do-while:\n\n";
                                cout << "do {\n";
                                cout << "        statement;\n";
                                cout << "} while(condition);\n";
                                cout << "\n";
                                break;
                        case '6':
                                cout << "The breake:\n\n";
                                cout << "break;\n";
                                cout << "\n";
                                break;
                        case '7':
                                cout << "The continue:\n\n";
                                cout << "continue;\n";
                                cout << "\n";
                                break;
                        case '8':
                                cout << "The got:\n\n";
                                cout << "goto label;\n";
                                cout << "\n";
                                break;
                }
                cout << "\n";
        }

        return 0;

}

---

very good ！

eh..how does "very good !" improve the code..

This looks suspicious:

Code:

---

if(choice < '1' || choice > '8' && choice != 'q')

---

If I remember correctly, && has higher precedence than ||, so that might not do what you want. (Try entering '9', it might break.) Even if it's correct it can be a good idea to parenthesize expressions where both && and || are involved (gcc even gives you a warning if you don't, if you want that particular warning enabled).

Also the if's condition is repeated in the while later on. I'd be inclined to make the loop infinite and use a break statement (as you've done with the outer for(;;) loop). Just a matter of style, some people dislike break/continue, but I prefer it to duplicated code.

Instead of lots of cout statements you can always write

Code:

---

std::cout << "hello there\n"
    << "again\n"
    << "and bye.\n";

---

or even

Code:

---

std::cout << "hello there\n"
    "again\n"
    "and bye.\n";

---

(The preprocessor concatenates string constants that are separated only by whitespace.)

Finally: the secret about switch statements? Arrays are often more convenient. :) For example:

Code:

---

const char *message[] = {
    // '1'
    "Comment for '1'\n"
    "some text\n"
    "and some more text.\n",

    // '2'
    "Comment for '2'\n"
    // ...
};

if(choice >= '1' && choice <= '8') {
    std::cout << message[choice - '1'];
}

---

Note that '0', '1', ... are guaranteed to be contiguous so there's no problem with this.