Thread & Classes

Hey i have this class:

Code:

---

class ClientHandler
{
      private:
          //   
      public:
        ClientHandler();
        ~ClientHandler(){}
        DWORD WINAPI ServeClient(LPVOID lpParam);
        DWORD WINAPI WaitClients(PVOID pvParam);
};

---

and in function WaitClients Im trying to create thread :

Code:

---

CreateThread(NULL, 0, ServeClient, (LPVOID)NextFreeSpace, 0, &thread_id);

---

Quote:

---

Units/ClientHandler.cpp: In member function `DWORD ClientHandler::WaitClients(void*)':
Units/ClientHandler.cpp:115: error: argument of type `DWORD (ClientHandler::)(void*)' does not match `DWORD (*)(void*)'

Units/ClientHandler.cpp: In member function `DWORD ClientHandler::ServeClient(void*)':

---

you cannot create a thread from a class member function using CreateThread() unless it is static. you can do it with boost::thread and boost::bind, so I would suggest looking at those to see if they will work for you, if this is something that you need to do with non-static functions.

This Boost C++ Libraries - Browse /boost/1.46.1 at SourceForge.net ?

There is no other way?

Sure. Create a function (either a global function, or a static member function of a class) that, in turn, invokes the member function on an object.

Ok, i will try. But i have question about crypt my connection, i would like to use openssl lib. So should it be done?

1. Client is sending to server his public key
2. Server random big number and crypt it with client's public key
3. Client use this big number to create secret key and send to server
4. Server use this same big number to create his secret key and send to client

And then server is using client's secret key to crypt and client is using server's secret key to crypt?

Why do you not want to use boost? You are aware that CreateThread is dangerous if you use C/C++ library functions, yes?

Quote:

---

Originally Posted by Elysia

Why do you not want to use boost? You are aware that CreateThread is dangerous if you use C/C++ library functions, yes?

---

I will try, i just don't like to complicate life by writing 10 lines instead of 1 :)

o_O
Boost makes life easier. Here is what boost would look like:

Code:

---

boost::thread thread(&ServeClient, NextFreeSpace);

---

And we're done!
If you want to wait on the thread, add

Code:

---

thread.join();

---

Quote:

---

Originally Posted by Elysia

o_O
Boost makes life easier. Here is what boost would look like:

Code:

---

boost::thread thread(&ServeClient, NextFreeSpace);

---

And we're done!
If you want to wait on the thread, add

Code:

---

thread.join();

---

---

Then i was wrong :P

But any clues about ssl?

I am not well versed in networking stuff, sorry. I have never used ssl from C++.

Ok :)

Btw, im trying to create thread this way u wrote but :

Units/ClientHandler.cpp:122: error: ISO C++ forbids taking the address of an unqualified or parenthesized non-static member function to form a pointer to member function. Say `&ClientHandler::ServeClient'

And when i try :

Code:

---

boost::thread thread(&ClientHandler::ServeClient, NextFreeSpace);

---

Then it shows me errors in bind_template.hpp

Not quite how it works. Member functions are coupled to instances, so you need to provide an instance in your parameter list. Eg:

Code:

---

ClientHandler handler;
boost::thread thread(&ClientHandler::ServeClient, handler, NextFreeSpace);

---

Where basically handler would be your instance of the class whose member function ServeClient you would like to call.
Btw, this would never work with CreateThread ;)
Savor the power of boost!

Quote:

---

Originally Posted by Elysia

Not quite how it works. Member functions are coupled to instances, so you need to provide an instance in your parameter list. Eg:

Code:

---

ClientHandler handler;
boost::thread thread(&ClientHandler::ServeClient, handler, NextFreeSpace);

---

Where basically handler would be your instance of the class whose member function ServeClient you would like to call.
Btw, this would never work with CreateThread ;)
Savor the power of boost!

---

Doing like this again shows me errors in bind_template.hpp

And this :

Code:

---

boost::thread thread(&ClientHandler::ServeClient, handler, (LPVOID)NextFreeSpace);

---

Units/ClientHandler.o(.text+0x2891):ClientHandler.cpp: undefined reference to `boost::thread::~thread()'
Units/ClientHandler.o(.text$_ZN5boost6threadC1IM13Client HandlerFmPvES2_S3_EET_T0_T1_[boost::thread::thread<unsigned long (ClientHandler::*)(void*), ClientHandler, void*>(unsigned long (ClientHandler::*)(void*), ClientHandler, void*)]+0xfa):ClientHandler.cpp: undefined reference to `boost::thread::start_thread()'

I'm using win7 and dev-c++.

This is right, actually. You need to compile boost and link to it (which the library should fix by itself, I believe). There are instructions at the boost homepage, or alternatively there might be binaries ready. I know there are for Visual Studio at least.
Oh, and don't cast NextFreeSpace to LPVOID.

EDIT: You might get binaries from here:
http://ascendwiki.cheme.cmu.edu/Bina...Boost_on_MinGW

Weird.. ihave installed binary and if i don't cast NextFreeSpace to LPVOID then i got errors in bind_template.hpp, but now if i cast to LPVOID it works, atleast compile :)

You should change your function to not accept LPVOID. NextFreeSpace should have a type. That's what you'll use in your function. That is, if you can. C++ preserves types, unlike C.

Yes, I had this because of CreateThread but now its not needed :) well looks nice :)

Btw what is returned as thread in :

Code:

---

boost::thread thread(&ClientHandler::ServeClient, CHandler, NextFreeSpace);

---

What type has this variable and what it represent?

The type is boost::thread and it represents your new thread. You can wait for it, query information, stop and resume it, and so on.

Quote:

---

Originally Posted by Elysia

The type is boost::thread and it represents your new thread. You can wait for it, query information, stop and resume it, and so on.

---

How can i assign it to Clients[NextFreeSpace].thread?

And its property set?

Code:

---

typedef struct TClient {
    boost::thread thread; //<-------
    SOCKET sock;
    struct sockaddr_in clientinfo;
  // class PacketProc PProc;
} TCLIENT, *PCLIENT;

---

I take it Clients is some array of boost::thread, then?
In such case, there might be two solutions:

boost::thread thread(...);
std::swap(Clients[NextFreeSpace].thread, thread);

Or

boost::thread thread(...);
Clients[NextFreeSpace].thread = std::move(thread);

With swap it says me its const boost and to move i have to include sth or ? It says its not member of std.

I have struct TClient which is info about connected client. I have also array of TClient named Clients. I need to store thread or pointer into struct too.

It sounds like one Clients[NextFreeSpace].thread is not assignable (it's const)?
Yes, std::move requires <utility> and C++0x.

Here is an example which works:

Code:

---

#include <boost/thread.hpp>
#include <algorithm>

class A
{
public:
        void foo(int) {}
};

int main()
{
        A a;
        boost::thread thread(&A::foo, a, 0);
        boost::thread thread2;
        std::swap(thread2, thread);
        return 0;
}

---

If your code doesn't work, then I can only assume that you cannot assign to Clients thread due to it being const. Code to demonstrate the problem perhaps?

I have something ..........ed up i guess.. even your example don't work.

Quote:

---

C:/Program Files (x86)/Boost-1.41.0/include/boost-1_41/boost/thread/detail/thread.hpp: In function `void std::swap(_Tp&, _Tp&) [with _Tp = boost::thread]':
Units/ClientHandler.cpp:124: instantiated from here
C:/Program Files (x86)/Boost-1.41.0/include/boost-1_41/boost/thread/detail/thread.hpp:108: error: `boost::thread::thread(boost::thread&)' is private
C:/Dev-Cpp/include/c++/3.4.2/bits/stl_algobase.h:130: error: within this context
C:/Program Files (x86)/Boost-1.41.0/include/boost-1_41/boost/thread/detail/thread.hpp:109: error: `boost::thread& boost::thread::operator=(boost::thread&)' is private
C:/Dev-Cpp/include/c++/3.4.2/bits/stl_algobase.h:131: error: within this context
C:/Dev-Cpp/include/c++/3.4.2/bits/stl_algobase.h:132: error: passing `const boost::thread' as `this' argument of `boost::thread::operator boost::detail::thread_move_t<boost::thread>()' discards qualifiers

---

Can u upload fixed stl_algobase.h? I guess it have not fixed problems.

Hmmm. I thought it would work. Are you using GCC? If so, you should try enabling C++0x mode.
Command line for GCC is: -std=c++0x
Maybe some option in an IDE if you use one.

Quote:

---

Originally Posted by kargo

I have something ..........ed up i guess.. even your example don't work.
I guess it have not fixed problems.

---

Sorry to intrude here, while you are in the middle of something..., but,
Kargo, you mentioned that:
1) you are using Dev-C++,
2) OS = Win7

1) what version of Dev-C++ are you using ?
2) have you gotten Dev-C++ to compile any program ?
3) where is the working folder where your project is located ?
4) when you compile, what does your complete compile log say ?


I ask these questions because Dev-C++ release 4.9.9.2 is the latest release of Dev-C++ and it dates back to 2005.
Dev 4.9.9.2 worked on XP (with caveats) and is know to have problems working on Vista and may not work at all on Win-7 .
Unfortunately, Colin LaPlace has abandoned further development on DevC++

That's why I ask question #2.
#3 is of particular importance too.

Have you read the "Read this before..." at the Dev-C++ forum:
SourceForge.net: Dev-C++: Topics for Bloodshed Software Forum

It does explain some of the many issues and problems of using Dev-C++.
Also, Dev-C++ is using an old version of GCC.

Just a thought.

Old version of GCC sounds bad. Perhaps it's time to upgrade. The easiest solution I can think of is Code::Blocks + the mingw compiler. That should get you started on using C++0x.
You might also try

Clients[NextFreeSpace].thread.swap(thread);
or
Clients[NextFreeSpace].thread = boost::move(thread);

Quote:

---

Originally Posted by Kargo

I'm using win7 and dev-c++.

---

Quote:

---

Originally Posted by Elysia

Old version of GCC sounds bad. Perhaps it's time to upgrade. The easiest solution I can think of is Code::Blocks + the mingw compiler. That should get you started on using C++0x.

---

Yes,
you can't simply use Dev-C++ with a newer version of GCC, it doesn't seen to work that way.
Dev-C++ (the IDE) is closely bound to that version of GCC.

Code::Blocks with MingW is a better option at this point.

I only use Dev-C++ for testing legacy code on an XP.
Where the issues and caveats are know to me and I can control them.

Unless you have Dev-C++ working, flawlessly, you may be beating a dead-horse.

Quote:

---

Originally Posted by Steve A.

Yes,
you can't simply use Dev-C++ with a newer version of GCC, it doesn't seen to work that way.
Dev-C++ (the IDE) is closely bound to that version of GCC.

Code::Blocks with MingW is a better option at this point.

I only use Dev-C++ for testing legacy code on an XP.
Where the issues and caveats are know to me and I can control them.

Unless you have Dev-C++ working, flawlessly, you may be beating a dead-horse.

---

Guess it's time to changes :)

I have problem, I'm using sockets and added lib by Project->Build Options->Linker Settings->Link Libaries. libwsock32 and libws2_32. But still I'm getting :

Quote:

---

\main.cpp|62|error: 'getaddrinfo' was not declared in this scope|

---

Did you include Wspiapi.h? MSDN says it's declared in there.

Quote:

---

Originally Posted by Elysia

Did you include Wspiapi.h? MSDN says it's declared in there.

---

No i don't but found solution :

Code:

---

#define _WIN32_WINNT 0x501

---

Quote:

---

Originally Posted by Elysia

Did you include Wspiapi.h? MSDN says it's declared in there.

---

No i don't but found solution :

Code:

---

#define _WIN32_WINNT 0x501

---

Including is ........ing me off :P

Share.hpp

Code:

---

#ifndef SHARE_H
#define SHARE_H

#ifndef NETWORK_HANDLER_H
    #include "NetworkHandler.hpp"
#endif

#ifndef CLIENT_HANDLER_H
    #include "ClientHandler.hpp"
#endif

#include <windows.h>
#include <winsock2.h>
#include <ws2tcpip.h>
#include <stdio.h>
#include <iostream>
#include <boost/thread/thread.hpp>

typedef BYTE PCK[65000];
typedef PCK *PPCK;
typedef BYTE Key16[16];

NetworkHandler NHandler; //<----------- ERROR : NetworkHandler does not name a type
#endif

---

NetworkHandler.hpp

Code:

---

#ifndef NETWORK_HANDLER_H
#define NETWORK_HANDLER_H
#include "share.hpp"

class NetworkHandler
{
    private:
        bool StartWSA();
        bool InitSock();
        bool CreateSock();
        bool BindSock();
        bool SetListener();
    public:
        SOCKET ListenSocket;
    //  NetworkHandler(){};
    //  ~NetworkHandler(){};
        bool Init();
};

#endif

---

ClientHandler.hpp

Code:

---

#ifndef CLIENT_HANDLER_H
#define CLIENT_HANDLER_H
#include "share.hpp"

class ClientHandler
{
      private:
          //
      public:
        ClientHandler();
        ~ClientHandler(){}
        void StartListen();
      //  DWORD WINAPI ServeClient(LPVOID lpParam);
        DWORD WINAPI ServeClient(int IDs); //<-------------- ERROR : DWORD does not name a type
        DWORD WINAPI WaitClients(PVOID pvParam); //<---------------- SAME
};

#endif

---

You have cycles in your headers. All header files rely on Share.hpp, but Share.hpp includes the others that depends on it.
You need to break those cycles.

>>NetworkHandler NHandler; //<----------- ERROR : NetworkHandler does not name a type
This should not be in a header. Global variables should be in .cpp files. Then you put
extern NetworkHandler NHandler;
in your header.

You might be able to get away with doing

class NetworkHandler;

before your extern declaration.
Or you simply break it off into another header file.
And I don't see why Share.hpp needs ClientHandler.hpp.

Quote:

---

Originally Posted by Elysia

You have cycles in your headers. All header files rely on Share.hpp, but Share.hpp includes the others that depends on it.
You need to break those cycles.

>>NetworkHandler NHandler; //<----------- ERROR : NetworkHandler does not name a type
This should not be in a header. Global variables should be in .cpp files. Then you put
extern NetworkHandler NHandler;
in your header.

You might be able to get away with doing

class NetworkHandler;

before your extern declaration.
Or you simply break it off into another header file.
And I don't see why Share.hpp needs ClientHandler.hpp.

---

Looks like #ifndef don't work in other headers?

Well so i put

Code:

---

class NetworkHandler;
extern NetworkHandler NHandler;

---

in my header, then i need to initilialize it somehow in share.cpp ?

When i try use it in main.cpp

Code:

---

NHandler.Init();

---

it says undefinied reference

Quote:

---

Originally Posted by kargo

Looks like #ifndef don't work in other headers?

---

Yes, they do, but they won't work as you expect in this case. Consider the code:

A.h:

Code:

---

#ifndef TEMP_20110316_1259
#define TEMP_20110316_1259

#pragma message( "Pre-include: Including A.h..." )
#include "Temp2.h"
#pragma message( "Post-include: Including A.h..." )

class A
{
        B b;
};

#endif

---

B.h:

Code:

---

#ifndef TEMP2_20110316_1259
#define TEMP2_20110316_1259

#pragma message( "Pre-include: Including B.h..." )
#include "Temp.h"
#pragma message( "Post-include: Including B.h..." )

class B
{
        A a;
}

#endif

---

When compiling, I get this output:
2> Pre-include: Including A.h...
2> Pre-include: Including B.h...
2> Post-include: Including B.h...
error C2146: syntax error : missing ';' before identifier 'a'
error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
2> Post-include: Including A.h...
error C2236: unexpected 'class' 'A'. Did you forget a ';'?
error C2143: syntax error : missing ';' before '{'
error C2447: '{' : missing function header (old-style formal list?)

What is happening?
A.h includes B.h.
B.h includes A.h.
B.h tries to include A.h. But the define has been defined, so it skips including its contents.
Here is the problem. Because A.h included B.h before the actual contents of the file, the declaration of A is missing at this point.
B.h assumes it has the declaration of A at this point and tries to use it, but it doesn't exist, so we get an error.

Quote:

---

Well so i put

Code:

---

class NetworkHandler;
extern NetworkHandler NHandler;

---

in my header, then i need to initilialize it somehow in share.cpp ?

---

Yes, you must put
NetworkHandler NHandler;
inside a .cpp file. Any source file.

So how can i do this?

Share.h

Code:

---

#include ...
#include ...

//Check if include caller is NetworkHandler
//if it is then dont do nothing here
//if it is not then :
#include "networkhandler.hpp"
//done

---

Why do it? Split your header files.
Put all common code into a specific header.
Then make two special headers: one for NetworkHandler, and one for the rest.

Quote:

---

Originally Posted by Elysia

Why do it? Split your header files.
Put all common code into a specific header.
Then make two special headers: one for NetworkHandler, and one for the rest.

---

I did like this :

- deleted from share.hpp
... #include "networkhandler.hpp"
... #include "clienthandler.hpp"
- I'm including share.hpp in cpp files for NHandler and CHandler
- In ClientHandler.cpp I do include NetworkHandler.h
- In NetworkHandler.cpp I do include ClientHandler.h

Is it good idea?

There are cycles in NetworkHandler.h and ClientHandler.h, is there? If not, and if those files need them, then it's good.
(Although, it is good programming practice to cut ties between different classes as much as possible.)
I don't know what NHandler and CHandler is, or what share.hpp is supposed to contain, so I can't say anything about that.

NHandler is NetworkHandler class which is responsible for make things like Init socket, set listener etc.
CHandler is ClientHandler class which is responsible for serving each client.
In share.hpp i have some includes like winsock etc. and declared some types and struct like Packet and Client.

What's the fastest way to move data from structure?

Like i call function which has pointer to my struct as argument, but into this function i want to move all structure to another variable (non pointer).

Like :

Code:

---

void func(PPACKET pck)
{
    TPACKET packet;
    packet = &pck;
}

---

Your code makes no sense. Anyway...
To make a copy, you simply do an assignment: a = b
If you don't want a copy, but merely another variable pointing to the same data structure, you can use a reference, say: MyType& a = b.

Quote:

---

Originally Posted by Elysia

Your code makes no sense. Anyway...
To make a copy, you simply do an assignment: a = b
If you don't want a copy, but merely another variable pointing to the same data structure, you can use a reference, say: MyType& a = b.

---

Yeah lol it should be * instead of &, my bad :D

Well i could but its like i use some struct for receive data from client and i need to free it as fast as possible to not block another packets. And again to this same variable i assign new data and again, again, again.

So I think i would just copy data from pointer, start thread and return from function. So i have free variable again to use for next incoming data and i'm processing last one in thread.

Anyway i'll have to do some safe about using the same var read/write to it from threads.

Boost has synchronizing functionality, as well. Just a heads up.
But from your description, it seems that you should just make a copy of the data received, or alternatively, tell your sockets to write the data directly to where you want to store it in order to process it.

Boost has synchronizing functionality, as well. Just a heads up.
But from your description, it seems that you should just make a copy of the data received, or alternatively, tell your sockets to write the data directly to where you want to store it in order to process it.