Thread: Classy question

A serious question this time.

I'm writing a C++ implementation of a DES encryptor (yeah, I know, but it's not really a problem with the encryptor code as such). As a bit of background, the DES algorithm consists of 3 steps.

1) Derive 16 subkeys from a user supplied key

2) Encrypt data with those subkeys

3) decrypt data with those subkeys

From this, and wanting to keep it as OO as possible, I decided to create an encryptor class. The constructor for this class is the part that derives the subkeys. There is an encrypt method in this class, and a decrypt method in this class.

First Q. Does this seem a reasonable way to structure my class? This way, for each change of key I can create a new encryptor object, ready to call the encrypt / decrypt methods.

Next Q. Can I call functions from my constructor? If so how - where do I put the definitions etc.

Last Q.

Code:

<snip>
class clsInitKeys             {
						char strKeyString[17];
						char strKeyn[17][49];
	
	
          public:
						char* GetKey(int x);
						clsInitKeys(char y[17] = "0123456789ABCDEF");
					};
<snip>

clsInitKeys::clsInitKeys(char y[17])
{

	strcpy (strKeyString, y);

<snip>

int main(void)
{
char key[17] = "0123456789abcdef";

<snip>

I really don't like passing that char array to the constructor. Is there a way I can pass a pointer instead??


THX,

Rob.

What functions? It's generally advisable to have your constructor do as little work as possible. It should only really initialise variables.

Mmmmmm that's my problem really, 'cos at the moment my constructor is doing loads of stuff by deriving the keys for me. Trouble is, I can't think of a better place to put that key derivation code. If I put it in a seperate member function, I'd have to remember to call that function before I could use my encryptor object. At the moment, I just create an encryptor object, and the subkeys are there ready to use.

I think I may have asked the last Q badly. At the moment, I am passing the whole string to the constructor (I think). What I want to do is just pass it the address of where the string is located(??), and that way not have to use that (ugly) strcpy.

call the key methods from your constructor

Just want to get this straight in my head..... you mean call the key methods from my encryptor object constructor, right? And presumably I could also create my key object from within the encryptor constructor (if I understand correctly).

BTW, I can't envisage wanting to change the keys once created - I think I'd prefer to destroy the "old" encryptor object and create a new one with the new key.

Thanks for your help - very much appreciated.