List of new-ed Pointers

Hi,

I have a standard list<my_obj*> and I need to iterate through it and remove all the objects that have a certain parameter my_obj.time>1.0f.

I've tried a number of things, but _Crt keeps finding memory leaks. The most recent:

Code:

for ( iter1=my_list->begin(); iter1!=my_list->end(); ) {
	(*iter1)->update(dt);
	if ( (*iter1)->time>=1.0f ) {
		iter2 = iter1;
		++iter2;
		my_list->remove( *iter1 );
		//adding "delete *iter" here causes access violation.
		if (iter2==my_list->end()) break;
		iter1 = iter2;
	}
	else ++iter1;
}

The code just keeps getting klugier and kludgier. This can't be the right way to do this.

Help?
Thanks,
Ian

Delete *iter before removing element from the list.

Huh. Could have sworn I'd tried that, but evidently I didn't. Thanks,

std::remove_if() reference

if you have a compiler that supports a subset of the C++0x standard (specifically lambdas and the redefined auto keyword) you could do something like this:

Code:

#include <algorithm>
std::list<my_obj*> myList;
auto it = std::remove_if(myList.begin(), myList.end(), [](my_obj* o)
{
  if (o->time > 1.0f)
  {
    delete o;
    return true;
  }
  else return false;
});
std::list<my_obj*> newList(myList.begin(), it);

newList now contains all elements for which the member 'time' was greater than 1.0f.

Use smart pointers in your list, ie std::list<std::shared_ptr<my_obj>>.

Originally Posted by Elysia

Use smart pointers in your list, ie std::list<std::shared_ptr<my_obj>>.

an excellent suggestion... wish I had thought of it