Switch-case not responding to operators

[manasij7479]

switch (s)
                {

                case '+':std::cout<<"D";break;
                case 'c':std::cout<<"D";break;
                
                }

This sounds somewhat silly..!...I remember doing this correctly years ago....but but now whenever s is '+' nothing happens.
Does stringstream or linux console input treat the operators differently (compared to characters)...There is a

if(in>>s ,s)

clause before the switch..(in being an input stringstream.)

[tabstop]

All this means is that you think the value of s is '+' when it isn't.

[manasij7479]

oo...Got the solution....apparently...it was bypassing the whole part and entering an if block above which had a condition of being a number to enter.......Why is + being treated as a number more preferably than a character?

[hutchid]

The switch(condition) clause is based on an integral value so when you pass a char to the switch it will upcast to an int to make the actual comparison!

[manasij7479]

but that applies to every character that can be entered....not only '+'...

[tabstop]

Then apparently your condition of being a number to enter isn't working. You should have been using isdigit(s) rather than trying to hardwire your own.

[manasij7479]

Does isdigit() work with floating points?
Consider the String entered:
sin 48.8 + cos 30

When I pass the input through the stringstream, and it is in the second iteration...would isdigit() make out 48.8 as a number?

[grumpy]

No.

Individual characters in your string would be passed to isdigit(). isdigit() is not used to check floating point values, and is not used to check substrings (unless by "check substring" you mean "check each character in the substring").

If "48.8" is being passed to isdigit() on the second iteration, you are presumably extracting substrings and using a conversion (aka cast) to pass it to isdigit(). That is not valid usage of isdigit().

[manasij7479]

no..I was actually reading the substring from the stream directly into a floating point variable and assuming that if that read failed , the part is not a number....but '+' somehow manages to arrive as the same place as the numbers....

[grumpy]

That's because, when reading data from a stream, the + sign indicates a positive value. So the string "+42" is interpreted as the numeric value 42.

You need to check for the presence of operators (or, more generally, anything that is not a digit or a separator) BEFORE extracting a numeric value from your string.

Your problem is not with switch/case. It is that you are reading data from your string before doing necessary checks on what that string contains.

[Xupicor]

Consider the String entered:
sin 48.8 + cos 30

Why not build your own little preprocessor that will separate your tokens with spaces, and then just read from stringstream to string: ss >> token;

After that you can check your token to see if it's an operator (not just + or -, but also lets say "sin", "and", "=", "==" - probably stored in a map? It can get a little bit messy if you wan't both + and ++, or = and == operators, but it's not hard), variable name ([a-zA-Z_]+[0-9_]*) or something else, which will probably be a numerical value. You can use stringstream to try and convert it to double (if that's your underlying type for that) - if it fails (leaves characters in the buffer) it's syntax error.