Thread: Read numbers from file to std::vector

Hello,
how to read all numbers from a file to std::vector?

I have tried this one:

Code:

ifstream in;
vector numbers;

   .
   .
   .

int number;
while (in.good())
{
    in >> number;
    numbers.push_back(number);
}

but if there (in the file) is not end of file right after the last number, then the while loop will pass one more time and put one "extra" number to my vector -> which is bad.

Does anybody know a solution to this problem?

Originally Posted by tabstop

So you (first) check whether the read is good, then you (second) do the read. C++ isn't psychic -- you have to read first, then check whether the read happened. Fortunately it's even easier done than said:

Code:

while (in >> number)

Thank you very much. It works!