Template trouble

I have the following class

Code:

// ZLine.h

#ifndef _ZLINE_H
#define _ZLINE_H

namespace Z_GLC {

template<typename T> class ZLine
{
    public:
        ZLine(T x1, T y1, T x2, T y2);

       double DistanceFromPoint(T x, T y);
    
    private:
       T a, b, c;
};

} // namespace

#endif

Code:

// ZLine.cpp

#include "ZLine.h"'

namespace Z_GLC {

template<typename T> ZLine<T>::ZLine(T x1, T y1, T x2, T y2)
{
    // implementation
}

template<typename T> double ZLine<T>::DistanceFromPoint(T x, T y)
{
    // implementation
}

} // namespace

When I try to use the class I get link errors. How to deal with this issue?

The functions of a template class should go in the header file (or at least, they should be "#include"'ed, not linked)...

You mean something like this ?

Code:

// ZLine.h

#ifndef _ZLINE_H
#define _ZLINE_H

namespace Z_GLC {

template<typename T> class ZLine
{
    public:
        ZLine(T x1, T y1, T x2, T y2);

       double DistanceFromPoint(T x, T y);
    
    private:
       T a, b, c;
};

} // namespace

#include "ZLine.cpp"

#endif

OFF TOPIC: Why can't the functions of a template class be linked?

Thanks for your help.

Originally Posted by Phenom

You mean something like this ?

Code:

// ZLine.h

#ifndef _ZLINE_H
#define _ZLINE_H

namespace Z_GLC {

template<typename T> class ZLine
{
    public:
        ZLine(T x1, T y1, T x2, T y2);

       double DistanceFromPoint(T x, T y);
    
    private:
       T a, b, c;
};

} // namespace

#include "ZLine.cpp"

#endif

OFF TOPIC: Why can't the functions of a template class be linked?

Thanks for your help.

Yes like that, but I wouldn't call it ".cpp" then. Call it ".hpp"; that's more common practice, as .cpp files should never be included.

Why it can't be done? Well, there exist compilers I think that can do it but it's extremely unportable. Because it's just very hard to implement, as it makes the .o file a lot harder, as it would need to store a lot more information than it does now.

Code:

#ifndef _ZLINE_H
#define _ZLINE_H

Nit... This violates the standard regarding reserved identifiers I believe:

7.1.3 Reserved identifiers
Each header declares or defines all identifiers listed in its associated subclause, and
optionally declares or defines identifiers listed in its associated future library directions
subclause and identifiers which are always reserved either for any use or for use as file
scope identifiers.
— All identifiers that begin with an underscore and either an uppercase letter or another
underscore are always reserved for any use.

Why can't the functions of a template class be linked?

Please see this link: templates, at the bottom of the page see the section titled: "Templates and multiple-file projects"

Jim

Just curious, which compilers can link template classes?

Originally Posted by Phenom

Just curious, which compilers can link template classes?

I've read once, if I remember correctly, that VC++ can do it. But I haven't tried it or verified it any way, and it was ages ago so I might remember wrong.

No compilers can link template classes (a compiler is a different thing from a linker).

g++ (the C++ compiler in the GNU compiler family) does support a feature it documents as "external template instantiations", which allow template functions and classes to be instantiated in a different source file from the source file that uses instances of the template - without needing to include the template source. Note this option is not enabled by default, but it has been supported since the mid 90s. By default, the technique described above (include the template source in the corresponding header) needs to be used.

Several versions of Borland's C++ compilers (which are used within suites like C++ Builder) support a similar behaviour.

Comeau C++ and (if memory serves) Sun Studio compilers support the export keyword (which is, approximately, the way the 1998 C++ standard sought to have such things done). However, the implementation of the "export" capability proved very complex and the benefits relatively small, so other compilers have not supported it. The export keyword will be either removed from the next C++ standard or deprecated (which is standardese for saying "obsolete and scheduled for removal from a future version of this standard").

Another question:

I have this:

Code:

template<typename T> class ZLine
{
     public:
         template<typename V> double DistanceFromPoint(std::vector<V> v);

    private:
        T a, b, c;

};

I try to write the implementation by typing:

Code:

template<typename T, typename V> double ZLine<T>::DistanceFromPoint(std::vector<V> v)
{
    // implementation
}

However I get errors. What's the right way to do this?

If I remember correctly:

Code:

template<class T>
template<class V>
double ZLine<T>::DistanceFromPoint(std::vector<V> v) 
{
    ...
}

I do question your passing a vector by value and not by (const) reference, though.

Thank you for helping, it works!

I do question your passing a vector by value and not by (const) reference, though.

In the actual code I don't use vectors. I just put it there to make more clear what I' m trying to do.

Roni's question is valid, however. For composite types (structs, classes) it is often better to pass by const reference than by value. Passing by value copies the complete object, and is not a good idea for objects with significant data that must be copied or for which the act of copying or cleanup is expensive (non-trivial constructors and destructors)