Need help on my project 2

[jturner38]

Write a program in C++ that evaluates portfix strings (one per line in a text file) with the following restrictions on the input: Each character is either an operand- if it is a digit and the floating point value associated with the digit, or it is one of the 5 binary operators: +, -, *, / (floating point), ^ (exponentiation). You must use a stack, in particular, the linked list implementation of the stack.

Here is what I got so far:

#include<iostream>
#include<cstdio>
#include<cmath>
using namespace std;

const int DefaultListSize =50;
typedef float Elem;
typedef char Link;


class Lstack {
private:
	Link*top;	/*Pointer to first element*/
	int size;	/*Count number of elements*/

public:
	Lstack(int sz =DefaultListSize) {top = NULL; size = 0;}
	~Lstack() {clear();}	/*Destructor*/
	void clear() {
		while (top != NULL) { /*Delete link nodes*/
			Link*temp = top;
			top = top->next;
			delete temp;
		}
		size = 0;
	}
	bool push(const Elem& item) {
		top = new Link(item,top);
		size++;
		return true;
	}
	bool pop(Elem& item) {
		if(size == 0) return false;
		item = top->element;
		Link *ltemp = top->next;
		delete top;
		top = ltemp;
		size--;
		return true;
	}
	bool topValue(Elem& it) const {
		if (size ==0) return false;
		it = top->element;
		return true;
	}
	int length() const {return size;}
	bool isEmpty() const {
		if (top == NULL) return true;
		else return false;
	};	
	float Eval(float oprndL, char oper, float oprndR){
		if(oper == '+') return oprndL + oprndR;
		else if(oper == '-') return oprndL - oprndR;
		else if(oper == '*') return oprndL * oprndR;
		else if(oper == '/') return oprndL / oprndR;
		else if(oper == '^') return pow(oprndL,oprndR);
		else return 0.0;
int main(){

	int v;
	bool operand(char ch){
		if(('0' <= ch) && (ch <= '9'))
			return true;
		else return false;
	}
	while(EOF){
		if(ch != '/n') if(operand(ch)) S.push(Val(ch));
		else {S.pop(oprndR);
			S.pop(oprndL);
			v = Eval(oprndL,ch,oprndR);
			S.push(v);
		}
	}
	else S.pop(answer);
	cout<< answer;
	return 0;
}

1>------ Build started: Project: Project 2, Configuration: Debug Win32 ------
1> Project 2.cpp
1>c:\users\justin\documents\visual studio 2010\projects\project 2\project 2\project 2.cpp(78): fatal error C1075: end of file found before the left brace '{' at 'c:\users\justin\documents\visual studio 2010\projects\project 2\project 2\project 2.cpp(51)' was matched
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

[Swarvy]

	};	
	float Eval(float oprndL, char oper, float oprndR){
		if(oper == '+') return oprndL + oprndR;
		else if(oper == '-') return oprndL - oprndR;
		else if(oper == '*') return oprndL * oprndR;
		else if(oper == '/') return oprndL / oprndR;
		else if(oper == '^') return pow(oprndL,oprndR);
		else return 0.0;

The error message is very revealing here. What is that semi-colon doing at the end of the function? Not to mention, you have another function after it called 'Eval', but there is no terminating '}' for that function. Those are your problems with this code.

[jturner38]

oh ok I see! The other thing it's giving me is that top is undefined in my Lstack. But I dont know if it should be int, char, or what.

[Swarvy]

Perhaps I am missing something, but at the start of the source code you have these two lines of code:

typedef float Elem;
typedef char Link;

Which is fair enough, you have defined Link as a character. Then in your class you define a pointer to type 'Link', which is again ok, but in the source code you have lines like the two below:

item = top->element;
Link *ltemp = top->next;

Am I missing something really obvious? Where does type 'Link' have a member called 'next' or 'element'? It is just a character.

Also, I was a little confused when I saw this code:

	bool operand(char ch){
		if(('0' <= ch) && (ch <= '9'))
			return true;
		else return false;
	}

The reason I was confused was that it looks a lot like a function but it is defined within the int main function! Do I need to continue with the explanation of how wrong that is?

You then have a while loop defined as this:

	while(EOF){

Do you realise that EOF is a macro? You don't even use it in the right context.

You then have lines like this:

S.push(Val(ch));

I can only presume that 'S' is the object instance of your class although you don't seem to ever call the constructor of your class.
Also, where is the function 'Val()' defined? I can't see the implementation of that function? Is implemented in another file? To the best of my knowledge it does not exist in any of the header files you included.

Are you moving in C++ from another language?