Probably a really simple problem.

[Nathan the noob]

  
if(Arrowkey == ENTERKEY)
{
       bool Check = ItemBuyBox(Itemarray[Arrowkeyplace]);
        if(Check == false)
        {
            BuyBoxClear();
        }
        else if(Check == true)
        {
            BuyItem(Itemarray[Arrowkeyplace]);
        }
}

No matter how i look at this i am unaware of how it always takes the first if regardless of what the function returns to check. It also takes both ifs if the second one isn't else. Im really unsure why this is happening :/
If i just put TRUE or FALSE it works fine :/

        else if(Arrowkey == ENTERKEY)
        {
            switch(Arrowkeyplace)
            {
                case 0:
                {
                    return true;
                }
                case 1:
                {
                    return false;
                }

            }
        }

This is the code that returns the BuyBox function.

If i get it to return the value to cout it outputs
184 for both true and false :/

[msh]

Show us the code for ItemBuyBox().

[Nathan the noob]

bool ItemBuyBox(string Itemname)
{
    //Variable Setup//
    string Question = "Would you like to purchase";
    string Yes = "Yes";
    string No = "No";
    bool Buying = true;
    int Arrowkeyplace = 0;
    char Arrowkey = '-';
    //Setup Question//
    BuyBoxClear();
    SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 7 );
    ReadString(Question,0,1,LeftSide+45,TopSide+18,2);
    ReadString(Itemname + "?",0,1,LeftSide+45,TopSide+19,2);
    SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 6 );
    ReadString(Yes,0,1,LeftSide+45+Itemname.size()+1+1,TopSide+19,2);
    SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 7 );
    ReadString("/",0,1,LeftSide+45+Itemname.size()+1+1+Yes.size()+1,TopSide+19,2);
    SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 11 );
    ReadString(No,0,1,LeftSide+45+Itemname.size()+1+1+Yes.size()+3,TopSide+19,2);
    //The Whileloop that controls the contained menu of yes/no//
    while(Buying)
    {
        while(!kbhit())
        {
            Sleep(1);
        }
        if(kbhit())
        {
            Arrowkey = getch();
            if(Arrowkey == 0)
            {
                Arrowkey = getch();
            }
        }
        if(Arrowkey == LEFTARROW)
        {
            Arrowkeyplace -= 1;
            if(Arrowkeyplace < 0)
            {
                Arrowkeyplace = 1;
            }
        }
        else if(Arrowkey == RIGHTARROW)
        {
            Arrowkeyplace += 1;
            if(Arrowkeyplace > 1)
            {
                Arrowkeyplace = 0;
            }
        }
        else if(Arrowkey == ENTERKEY)
        {
            switch(Arrowkeyplace)
            {
                case 0:
                {
                    return(true);
                }
                case 1:
                {
                    return(false);
                }

            }
        }
        if(Arrowkey == LEFTARROW || Arrowkey == RIGHTARROW)
        {
            if(Arrowkeyplace == 0)
            {
                SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 6 );
                ReadString(Yes,0,1,LeftSide+45+Itemname.size()+1+1,TopSide+19,2);
                SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 7 );
                ReadString("/",0,1,LeftSide+45+Itemname.size()+1+1+Yes.size()+1,TopSide+19,2);
                SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 11 );
                ReadString(No,0,1,LeftSide+45+Itemname.size()+1+1+Yes.size()+3,TopSide+19,2);
            }
            else if(Arrowkeyplace == 1)
            {
                SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 11 );
                ReadString(Yes,0,1,LeftSide+45+Itemname.size()+1+1,TopSide+19,2);
                SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 7 );
                ReadString("/",0,1,LeftSide+45+Itemname.size()+1+1+Yes.size()+1,TopSide+19,2);
                SetConsoleTextAttribute( GetStdHandle( STD_OUTPUT_HANDLE ), 6 );
                ReadString(No,0,1,LeftSide+45+Itemname.size()+1+1+Yes.size()+3,TopSide+19,2);
            }
        }
    }
}

And it is surely contained in this and any functions that are user made out side of this are free of this error.

[msh]

Are the following variables global?
Arrowkeyplace
Arrowkey

I would start by changing this...

if(kbhit())
{
    Arrowkey = getch();
    if(Arrowkey == 0)
    {
        Arrowkey = getch();
    }
}

To this...

if(kbhit())
{
    Arrowkey = getch();
    while (Arrowkey == 0)
    {
        Arrowkey = getch();
    }
}

[Nathan the noob]

No those 2 variables are not global i declared them at the beginning of the header.
The LEFTARROW RIGHTARROW ENTERKEY are global.

[laserlight]

No those 2 variables are not global i declared them at the beginning of the header.

That actually makes it sound like they are global.

[Nathan the noob]

No i meant its in the beginning of the header within both functions.

[Elysia]

Say what? How about you just show an example of your header file with these functions and these variables?

[Nathan the noob]

The function above shows how i init and use the variables.