Whats wrong with this...

This is my code:

Code:

#include "backtobasics.h"
#include "baic2.h"

using namespace std;

int menu()
{
    int choice;

    cout << " **** Menu ****" << endl << endl;  //States the options on the menu 
    cout << "(1) Play Game." << endl;
    cout << "(2) Options." << endl;
    cout << "(3) Multiplayer." << endl;
    cout << "(4) Quit." << endl << endl;

    cout << ": ";
    cin >> choice;  //enter there choice, 1,2,3 or 4
    return choice;
	return 0;
} 
  int main()
  {
    int choice = menu(), i, second;  
	string firstName, lastName;
    cout << "You chose option " << choice << endl;  //tells the user their choice
	cout << "Is this correct? If yes click 1, if no click 2. (2 mistakes Remaining)" << endl;  //asks them if it is correct (1) or not (2) 
		cout << " (1)"<<endl;
		cout << " (2)"<<endl;
		cin>>second;  //they enter their choice 1 or 2
if (second==1){ // if they enter 1, it says that they can continue
			cout<< "Click to continue."<<endl;
			cin.get();
			return 0;
}
		else if (second==2) // if they enter 2, it gives them the menu again
		{
			cout << " **** Menu ****" << endl << endl;  //States the options on the menu 
    cout << "(1) Play Game." << endl;
    cout << "(2) Options." << endl;
    cout << "(3) Multiplayer." << endl;
    cout << "(4) Quit." << endl << endl;

    cout << ": ";
    cin >> choice;  //enter there choice, 1,2,3 or 4
    int menu(), i, second;  

    cout << "You chose option " << choice << endl;  //tells the user their choice
	cout << "Is this correct? If yes click 1, if no click 2. (1 mistake Remaining)" << endl;  //asks them if it is correct (1) or not (2) 
		cout << " (1)"<<endl;
		cout << " (2)"<<endl;
		cin>>second;  //they enter their choice 1 or 2
if (second==1){ // if they enter 1, it says that they can continue
			cout<< "Click to continue."<<endl;
			cin>>i
				;
			return 1;
		}
		else if (second==2) // if they enter 2, it gives them the menu again
		{
			while (second==2)
				second++;
				cout << " **** Menu ****" << endl << endl;  //States the options on the menu 
    cout << "(1) Play Game." << endl;
    cout << "(2) Options." << endl;
    cout << "(3) Multiplayer." << endl;
    cout << "(4) Quit." << endl << endl;

    cout << ": ";
    cin >> choice;  //enter there choice, 1,2,3 or 4
    return choice;


		}
}
		else (second>2);  // if they enter a number bigger than 2, it tells them that it is invalid
		{
			cout<<"You have not entered a valid choice."<<endl;
			cin>>i;
			return 1;
		}
		{
	cout<<"Welcome, what is your name? First and Last. "<<endl;
		cin>>firstName>>lastName;
	cout<<endl<<"Hello " << firstName << lastName;
	cin.get ();
	return 0;
  }
		return 0;
  }

The bottom part does not play. Does anyone know why?

Code:

{
	cout<<"Welcome, what is your name? First and Last. "<<endl;
		cin>>firstName>>lastName;
	cout<<endl<<"Hello " << firstName << lastName;
	cin.get ();
	return 0;
  }

It would help if you indented your code properly, e.g.,

Code:

#include "backtobasics.h"
#include "baic2.h"

using namespace std;

int menu()
{
    int choice;

    cout << " **** Menu ****" << endl << endl;  //States the options on the menu
    cout << "(1) Play Game." << endl;
    cout << "(2) Options." << endl;
    cout << "(3) Multiplayer." << endl;
    cout << "(4) Quit." << endl << endl;

    cout << ": ";
    cin >> choice;  //enter there choice, 1,2,3 or 4
    return choice;
    return 0;
}

int main()
{
    int choice = menu(), i, second;
    string firstName, lastName;
    cout << "You chose option " << choice << endl;  //tells the user their choice
    cout << "Is this correct? If yes click 1, if no click 2. (2 mistakes Remaining)" << endl;  //asks them if it is correct (1) or not (2)
    cout << " (1)"<<endl;
    cout << " (2)"<<endl;
    cin>>second;  //they enter their choice 1 or 2
    if (second==1){ // if they enter 1, it says that they can continue
        cout<< "Click to continue."<<endl;
        cin.get();
        return 0;
    }
    else if (second==2) // if they enter 2, it gives them the menu again
    {
        cout << " **** Menu ****" << endl << endl;  //States the options on the menu
        cout << "(1) Play Game." << endl;
        cout << "(2) Options." << endl;
        cout << "(3) Multiplayer." << endl;
        cout << "(4) Quit." << endl << endl;

        cout << ": ";
        cin >> choice;  //enter there choice, 1,2,3 or 4
        int menu(), i, second;

        cout << "You chose option " << choice << endl;  //tells the user their choice
        cout << "Is this correct? If yes click 1, if no click 2. (1 mistake Remaining)" << endl;  //asks them if it is correct (1) or not (2)
        cout << " (1)"<<endl;
        cout << " (2)"<<endl;
        cin>>second;  //they enter their choice 1 or 2
        if (second==1){ // if they enter 1, it says that they can continue
            cout<< "Click to continue."<<endl;
            cin>>i
            ;
            return 1;
        }
        else if (second==2) // if they enter 2, it gives them the menu again
        {
            while (second==2)
                second++;
            cout << " **** Menu ****" << endl << endl;  //States the options on the menu
            cout << "(1) Play Game." << endl;
            cout << "(2) Options." << endl;
            cout << "(3) Multiplayer." << endl;
            cout << "(4) Quit." << endl << endl;

            cout << ": ";
            cin >> choice;  //enter there choice, 1,2,3 or 4
            return choice;
        }
    }
    else
        (second>2);  // if they enter a number bigger than 2, it tells them that it is invalid

    {
        cout<<"You have not entered a valid choice."<<endl;
        cin>>i;
        return 1;
    }
    {
        cout<<"Welcome, what is your name? First and Last. "<<endl;
        cin>>firstName>>lastName;
        cout<<endl<<"Hello " << firstName << lastName;
        cin.get ();
        return 0;
    }
    return 0;
}

if you look at lazerlights example of proper indentation, then it becomes easier to notice the problem. Focus on your opening and closing braces... ask yourself why are those braces around the code that isn't running....

i have tried laserlights code and this doesn't work either?

Lol he didn't change your code content he indented it(changed format). I gave you a hint... did you look at what I said?

its all gobldy gook to me. I'm new, what does your code mean? i've never seen anything like it before.

It's just YOUR code reformatted so the rest of us can read it without going blind.

Here's one free tip.
> else
> (second>2); // if they enter a number bigger than 2, it tells them that it is invalid
else has no conditional exression, it is simply everything left over after all the if and else if conditions.

Here's another tip
A development process
Write the code in small parts you CAN understand.
Like for example, print the menu and get the input WITHOUT doing anything other than printing "You chose option 1".

What isn't going to work is for you to write the whole thing in one edit session, find that inevitably, it won't compile, then dump the whole mess on a forum for someone else to fix.

Originally Posted by ftball22

its all gobldy gook to me. I'm new, what does your code mean? i've never seen anything like it before.

I lol'd

I mean, shouldn't you recognize your own code, even if a few spaces are added? I can't imagine why anyone wouldn't; unless it's not your own code in the first place of course.

Sadly I think he was refering to my signature thinking it was code I was posting to help him, rather than reading my actual suggestion.