File stream to char* help

I'm trying to take data from a file stream and put it into a char*. (I know using strings is better.. but I'm kind of being forced to do so). And so I have the code below almost working like it should, but I get two extra characters at the end. How can I fix that?

Code:

---

#include <iostream>
#include <fstream>
#include <cstring>

int main()
{
  std::ifstream dataFile("strings.txt"); // strings.txt contains "this is my string" or w/e

  char* str = new char[];

  int i = 0;
  while(!dataFile.eof())
  {
          dataFile >> str[i];
        i++;
  }

  std::cout << str;

  return 0
}

---

I'm not really concerned about losing spaces, since in the end I just need the letters of the alphabet for something I would do later.

That program should not even compile since you did not specify the size when using the new[] operator.

Now, you should not be using eof() to control the loop: eof() only returns true after the EOF condition is detected, causing you to read one more time than you want to. Rather, you should write:

Code:

---

int i = 0;
while (dataFile >> str[i])
{
    i++;
}

---

or more simply:

Code:

---

for (int i = 0; dataFile >> str[i]; ++i);

---

But here is a limitation: if you specify some size when using the new[] operator, you would then be able to read at most that number of characters. Unfortunately, you do not know beforehand how many characters will have to be read. Consequently, you need to track the size (as in number of characters read) and the capacity (as in the number of characters allocated), and expand the dynamic string when necessary (usually by increasing the capacity by some factor greater than 1 to create a new string, and then copying over the characters from the old string to the new string, and then destroying the old string so that you can work fully with the new string).

Of course, remember to delete[] what you new[].

But see, when I specify how big I want my dynamic array to be, then I still get random characters at the end of it. And even more of them.

Thank-you for the advice on how to set up the while loop though. :)

After the while loop, you need to NULL terminate the char * string, like

Code:

---

str[i] = '\x0';

---

Quote:

---

Originally Posted by #2Pencil

But see, when I specify how big I want my dynamic array to be, then I still get random characters at the end of it. And even more of them.

---

That's why you keep track of how much of the array is actually being used.

Quote:

---

Originally Posted by Jamdog

After the while loop, you need to NULL terminate the char * string, like

Code:

---

str[i] = '\x0';

---

---

It worked! Thank-you so much! :)