Help me with eof

this is my code:

Code:

#include<iostream>
#include<fstream>

using namespace std;

void readChar(ifstream &inSFile);

int main()      {

ifstream in("in.txt");
readChar(in);
}

void readChar(ifstream &inSFile)        {
        char ch;
        do{
                while(inSFile.get(ch))  {
                        cout << ch;
                        if(ch=='\n')    {
                                break;
                        }
                }
                cout << "got a new line"<<endl;
        } while(ch == '\n' && !inSFile.eof());
}

this is my in.txt:

Code:

666666
7777777
88888888

Output:

Code:

666666
got a new line
7777777
got a new line
88888888
got a new line
got a new line

The last line "got a new line" is unexpected, how can I fix it?

By only using one while loop perhaps?

Also, you read a character WITHOUT testing for eof, then go ahead and do something anyway.
Most likely, ch still contains the previous input.

while ( inSFile.get(ch) )
reads the whole file, and exits when it hits eof.

I use two loops just because I wanted to process each line each time,

as you said I am reading character without testing for eof, in such case,
It won't enter into

Code:

while(inSFile.get(ch)) {
//loop
}

As you said it exits when it hits eof, why in this case it is going through an extra loop even if the file ends, is there any way to stop this extra iteration?

Originally Posted by kapil1089thekin

as you said I am reading character without testing for eof, in such case,
It won't enter into

Code:

while(inSFile.get(ch)) {
//loop
}

This is not true. I suspect you are thinking that get() returns an integer which will correspond to the character read, or some negative value in the case of EOF. However, the return value of get(char& c) is a reference back to the stream. If you want the version that returns an integer, you have to do

Code:

ch = inSFile.get(); // Returns integer

get - C++ Reference

Edit: And if it isn't clear, ch should be of type int if it is going to be able to handle EOF.

Do I need to use:

Code:

 while (is.good())  {
//code
}

????

Yes, you could follow what the example in that link did. I don't like it as much because it needs to check for EOF twice. You can make it more compact while still being readable IMO. Perhaps something like (taking advantage of the fact that istream.get(char& c) returns a reference to itself):

Code:

char ch;
while (inSFile.get(ch).good()) {
  // code; ch will hold the character read
}

Yes, you could follow what the example in that link did. I don't like it as much because it needs to check for EOF twice.

Does it? There should be no difference.

Code:

    std::ifstream file;
    std::string path;
    std::getline (std::cin , path);
    file.open (path.c_str ());
    if (file.is_open ()) {
        char c;
        c = file.get (); // primary read
        while (file) {
            std::cout.put (c);
            c = file.get (); // driving read
        }
        file.close ();
    }

Perhaps the original source forgot something.

How about as Salem suggested:

Code:

void readChar(ifstream &inSFile) {
   char ch;
   while(inSFile.get(ch))  {
      cout << ch;
      if(ch=='\n')    {
         cout << "got a new line"<<endl;
       }
   }
}

Ah, I didn't realize the while condition would evaluate to false when EOF was encountered.

I'm curious though about ch being of type char. get() returns an int, so I was expecting that g++ with -Wall was going to warn me about possible loss of data? But it compiled without any warnings.

The code I was referring to from the link I posted is:

Code:

// istream get
#include <iostream>
#include <fstream>
using namespace std;

int main () {
  char c, str[256];
  ifstream is;

  cout << "Enter the name of an existing text file: ";
  cin.get (str,256);

  is.open (str);        // open file

  while (is.good())     // loop while extraction from file is possible
  {
    c = is.get();       // get character from file
    if (is.good())
      cout << c;
  }

  is.close();           // close file

  return 0;
}

Originally Posted by jimblumberg

How about as Salem suggested:

Code:

void readChar(ifstream &inSFile) {
   char ch;
   while(inSFile.get(ch))  {
      cout << ch;
      if(ch=='\n')    {
         cout << "got a new line"<<endl;
       }
   }
}

Yeah, knowing what I now do about the stream evaluating to false when EOF is encountered, I agree this is probably the nicest approach. Cleaner looking that "while(inSFile.get(ch).good())" and does the same thing.

Honestly, I prefer Salem's as well, but as I pointed out, you can write the original source so it doesn't check the stream twice. It turns out it did forget to do a primary read, so the double check was required.

Originally Posted by jason_m

I'm curious though about ch being of type char. get() returns an int, so I was expecting that g++ with -Wall was going to warn me about possible loss of data? But it compiled without any warnings.

Afaik, GCC doesn't emit narrowing warnings.