Thread: EOF not working as I need

forum.cpp contains

Code:

#include<iostream>
#include<fstream>
using namespace std;
int main(){
        ifstream in("forum.txt");
        int i;
        while(!in.eof())        {
                in>>i;
                cout <<i <<" ";
        }
}

forum.txt contains

Code:

 1 2 3

When I am running the program forum.cpp
its printing:

Code:

1 2 3 3

Why and how to solve it?

eof only returns false after a failed read. So the last read fails, but you never checked for its success. Use something like:

Code:

while(in >> i)

thanks it worked!