Thread: Bubble sort isnt completely working

so i basically looked at some pseudo code and tried to code it but when i run it i get like one number out of order, any idea?

Code:

#include <iostream>

using namespace std;

#define NUMBER_OF_ELEMENTS 15


int main(){
    int toSort[NUMBER_OF_ELEMENTS];

    cout<< "Enter the numbers:\n ";
    for (int i = 0; i < NUMBER_OF_ELEMENTS; i++){
        cout<< "\n\t";
        toSort[i] = rand();
    }

    bool sorting = true;
    do{
        int total = 0;
        for(int b = 0; b <= NUMBER_OF_ELEMENTS; b++){
            if(toSort[b + 1] < toSort[b]){
                int tmp = toSort[b];
                toSort[b] = toSort[b + 1];
                toSort[b + 1] = tmp;
            }
            else{
                total++;
            }
        }
        if (total >= NUMBER_OF_ELEMENTS){
            sorting = false;
        }
    } while(sorting == true);

    cout<<"Everything sorted:";

    for (int z = 0; z < NUMBER_OF_ELEMENTS; z++){
        cout<<"\n\t";
        cout<<toSort[z];
    }

}

Okay guys thanks for the input, I went back and edited the code, and I actually meant to ask about a function to swap memebers of any array in the op. Anyway this works, and I changed it to where it doesn't have a counter and makes sorting true again, so it will keep looping, but if i remember correctly my execution time was less when i had the counter.

Code:

#include <iostream>

using namespace std;

#define NUMBER_OF_ELEMENTS 200


int main(){
    int toSort[NUMBER_OF_ELEMENTS];

    for (int i = 0; i < NUMBER_OF_ELEMENTS; i++){
        toSort[i] = rand();
    }

    bool sorting = true;
    do{
        sorting = false;
        int total = 0;
        for(int b = 1; b < NUMBER_OF_ELEMENTS; b++){
            if(toSort[b - 1] > toSort[b]){
                swap(toSort[b], toSort[b - 1]);
                sorting = true;
            }
        }
    } while(sorting == true);

    cout<<"Everything sorted:";

    for (int z = 0; z < NUMBER_OF_ELEMENTS; z++){
        cout<<"\n\t";
        cout<<toSort[z];
    }

}