Problem calling class function.

Okay, so it's me again

I have declared a vector and function within a class

Code:

vector<Book> Books;
void add_books(vector<Book>&);

I have defined the function within a .cpp file

Code:

void Library::add_books(vector<Book>& b)
{

	//do something
	
}

However, when I call the function, I think I am passing the argument incorrectly. I have tried as such:

Code:

Library::add_books(Library::Books);

But I get the following error:

error C2597: illegal reference to non-static member 'Library::Books

Any wise words of wisdom?

Thanks.

What is Library? Is it a class?
Also, don't remove the names of the parameters in the prototypes: SourceForge.net: Do not remove parameter names - cpwiki

Originally Posted by Elysia

What is Library? Is it a class?
Also, don't remove the names of the parameters in the prototypes: SourceForge.net: Do not remove parameter names - cpwiki

Hello,

Yeah, Library is the class.

Cheers.

Then you have to create an instance of the Library first and call its member function add_books.
Also, I don't see the need for Books to be inside the Library class?
What are you trying to accomplish?

Originally Posted by Elysia

Then you have to create an instance of the Library first and call its member function add_books.
Also, I don't see the need for Books to be inside the Library class?
What are you trying to accomplish?

I am following suggestions from an exercise within one of Stroustrups books.

I have already designed a book class and the vector within the LIbrary class is to hold all of the book information.

So I am thinking of creating a Library object that holds all the book objects, within the vector that :
a)have already been created within the code, and
b)the user will be able to add via a Library member function.

So essentially, if I wish to use the add_book function to store books within the Book vector, I will first need to create a Libryary object that is constructed with the Book vector as an argument.

Is that correct?

Thanks.

OK, certainly that is valid approach. However, note that the vector holding the books is an internal member of the class. That is, the class uses this to store information about the books. You shouldn't have access to it from the outside. You don't need to know how the Library stores the book information. You only need to know how to use it. This is the principle we strive to attain.
So, the add_book function should either add a new book to the library or several new books.
It could look something like:

Code:

Library MyLibrary;
Book MyBook1("My book 1"), MyBook2("My book 2");
MyLibrary.add_book(MyBook1);
std::vector<Book> Books;
Books.push_back(MyBook1);
Books.push_back(MyBook2);
MyLibrary.add_book(Books);

Thanks for that. Will put that into code shortly.