Thread: what's the best way to achieve this

I'm not at a computer right now but i see a couple of things.

1. I personally would break each stage of the input up to make it easier, and consequently, easier to track down your bugs.

2. Cin.get() is unecessary if the user input is wrong, and is likely having a negative affect on the conditions of your while loop

Strlen is for c style char arrays, you want .length()

Oke,

Does anyone know how I can check if a input only contains numbers ?

Roelof

Edit 1 :

The only thing I can think is to make a loop and check everything in the string seperate.
with converting yoiu have the problem that if the string contains 0 converting give the same answer if string contains a.

Why bother converting from a string to an int? Strings are obviously more flexible than ints for user input. With strings a user can enter "1", "one", "One", or "ONE" which all mean the same thing. If the string matches any of those, then assign the value 1 to an integer.

Code:

^[\d]+$

Hello,

I have googled but this seems to be a print solution.
I was looking for input validation that the string only contains numbers.

Roelof

Edit :

can this be a good solution:

Code:

int myNumber = 0;

 while (true) {
   cout << "Please enter a valid number: ";
   getline(cin, input);

   // This code converts from string to number safely.
   stringstream myStream(input);
   if (myStream >> myNumber)
     break;
   cout << "Invalid number, please try again" << endl;
 }
 cout << "You entered: " << myNumber << endl << endl;

can someone tell me what mystream >> mynumber means ?