Thread: Tree Insert

I have made a class of tree with 12 children. I insert the data in the tree systematically, Like first root, then first children , second children, and so on.
I am having problems in coding this function.
I am sharing with you, whatever i have managed so far.
here is the code, Kindly help with the insert function.

Code:

class Node
{
	public:
	char data[25];
	Node *next[12];
	
};

class Tree
{
	Node* root;
	
public:
	Tree()
	{
		root=NULL;
		
	}
		
	void insert(char a[25])
	{
		Node* temp = new Node();
			
		strcpy(temp->data,a );
		//temp = root;
		for (int i = 1; i < 13; i ++)
			temp->next[i] = NULL;
		
		
		
		for (int i = 1; i <13; i ++)
		{
			if (temp->next[i] == NULL)
				strcpy(temp->data,a);
			//break;
			return;
		}

		for (int i= 1; i < 13; i++)
		{
			temp = temp->next[i];
			for (int i = 1; i <13; i ++)
			{
				if (temp->next[i] == NULL)
				strcpy(temp->data,a);
				//break;
				return;
			}
			temp = root;
		}

		for (int i= 1; i < 13; i++)
		{
			temp = temp->next[i]->next[i];
			for (int i = 1; i <13; i ++)
			{
				if (temp->next[i] == NULL)
				strcpy(temp->data,a);
				return;
			}
			temp = root;
		}
		
	}

	void treeSearch(char a[25])
	{
		Node* temp;
		temp = root;
		bool flag = false;

		for ( int i = 1; i < 13; i++ )
		{
			if (strcmp(temp->next[i]->data,a)== 0)
			{
				flag = true;
				cout<<"Found";
				break;
			}
			
		}

		if ( flag == false)
		{
			for ( int i = 1; i < 13; i++ )
			{
				temp = temp->next[i];
				for (int i = 1; i < 13; i++ )
				{
					if (strcmp(temp->next[i]->data,a)== 0)
					{
						flag = true;
						cout<<"Found";
						break;
					}
				}
				temp = root;
			}
		
			for ( int i = 1; i < 13; i++ )
			{
				temp = temp->next[i]->next[i];
				for (int i = 1; i < 13; i++ )
				{
					if (strcmp(temp->next[i]->data,a)== 0)
					{
						flag = true;
						cout<<"Found";
						break;
					}
				}
				temp = root;
			}
		
		}

		
	}

If you have 12 items in an array, they are numbered 0 through 11, not 1 through 12.

If you intend to always insert in order, it may not be a bad idea to just store a pair of numbers for the "next" place to insert so you don't have to try and find it each time. If you're not necessarily inserting in order, then you need to know (whether by passing in a parameter, or by setting a criteria) where the new object is supposed to go.

You'll also need to have root involved somehow.

Originally Posted by tabstop

You'll also need to have root involved somehow.

Didn't get you , How to involve the root. Plus I m making the tree of height 2.

Originally Posted by Fatima Rizwan

Didn't get you , How to involve the root. Plus I m making the tree of height 2.

You're trying to insert temp into temp. You need to make your new object temp, and then hook it onto the root of the tree (by saying root->next[5] = temp or whatever).

Maybe I am looking at your code wrong, but are you just inserting "randomly" and then searching brute force wise thru every node?

I had thought the purpose of a tree was to place lower values to the left and higher values to the right, so you can get something like O(log(n)) lookups.

Originally Posted by MK27

I had thought the purpose of a tree was to place lower values to the left and higher values to the right, so you can get something like O(log(n)) lookups.

That's the purpose of a binary search tree, yes. Not all trees are BST, though, and when you see the phrase "every node has 12 children" that may be a hint. (What the purpose of this particular tree is, I have no idea.)