Thread: Getting strings from a string

I just installed Ubuntu and these 2-3 days I haven't been able to log in here. I had a thread opened here. The problem is solved now, so forgive me for not telling about it.

What I want to do now is to get strings from a string. If I have the following string:

" this + that - anotherOne + again ",

then I am going to have a string called "this", another one called "that", and so on, without the spaces. here is my code:

Code:

vector<string> siruriCitite;

void f(string sir)
{
    int pointer = 0;
    int length = sir.length();
    int found = 0;
    int firstLetter, lastLetter;
    int dimension = 0;
    do
    {
        firstLetter = sir.find_first_not_of(" ", found + 1);
        lastLetter = sir.find_last_not_of(" ", found + 1);
        for(pointer = found; pointer < length; pointer++)
        {
            if(sir[pointer] == '+' || sir[pointer] == '-' || sir[pointer] == '/')
            {
                found = pointer;
                break;
            }
        }
        siruriCitite.resize(dimension + 1);
        siruriCitite[dimension] = sir.substr(firstLetter, lastLetter);
        dimension++;
    }
    while(pointer < length);
}

After running in main : f("CradleofFilth + TheCruxshadows - Ubuntu / SoporAeternus") and then

Code:

     int l = siruriCitite.size();
    for(int i = 0; i < l; l++)
    {
        cout << siruriCitite[l] << endl;
    }

, nothing happens. It's like an infinite loop. Also, the operating system almost crashes.. Thank you in advance for your time ..

A simpler way for tokenizing on whitespace would be to use a stream.

Code:

std::stringstream ss(input);
std::string token;
while (ss >> token) {
    //throw away operators if needed
    results.push_back(token);
}

Also it is a very bad idea to resize the vector manually. You are just giving up the (amortized) constant time insertions at the end that the vector offers, instead requiring all insertions to have linear complexity. Plus it is more error prone.