Thread: Program closing early?

Thanks for the quick response.

I've had a look at what you have said and have found the cin.clear() and cin.ignore() member functions. Is that the best way to achieve this? I have used both as such:

Code:

vector<int> numbers;

	cout << "Please enter a list of numbers ";
	int temp;
	
	while(cin>>temp)
		numbers.push_back(temp);

	cin.clear();
	cin.ignore();
	
	
	cout << "How many elements do you wish to sum? ";
	
	int sum;
	cin >> sum;

	system("pause");

It works fine now, just wondering if that's acceptable practise?

Thanks again.

well, ending your while loop by breaking it with a letter is kind of goofy.

you could have user enter all the numbers on a single line and use getline, then push them into vector using a stringstream.

for example!

Code:

#include <iostream>
#include <sstream>
#include <vector>

using namespace std;
int main()
{
	string str_num;
	int current_number;
	vector<int> numbers;

	cout << "Please enter a list of numbers ";

	getline(cin , str_num);
	 // takes a complete line (discarding newline character as well)

	istringstream iss(str_num); 
	 // inserts string into a stream (you should learn streams they are useful)

	// now you can use this stream just as you would cin, which is a stream itself actually
	while(iss >> current_number)
		 numbers.push_back(current_number);

	cout << "How many elements do you wish to sum? ";
	
	int sum;
	cin >> sum;

	system("pause");

}

GL!

Code:

int i=1;
while(i!=0){// "enter 0 to stop the loop, or some other criterion
     cin>>i;
      elements.push_back(i);
 }
cout<<"how many elemets to add?";
cin>>i;
int j(0);
for(int k(0); k<i; k++){
    j+=elements[k];
}
cout<<" heres the TOTAL "<<j<<" TA DA"<<endl;

There could be array bounds checking on stuff too, but i am lazy ok?

Originally Posted by rodrigorules

well, ending your while loop by breaking it with a letter is kind of goofy.

you could have user enter all the numbers on a single line and use getline, then push them into vector using a stringstream.

for example!

Code:

#include <iostream>
#include <sstream>
#include <vector>

using namespace std;
int main()
{
	string str_num;
	int current_number;
	vector<int> numbers;

	cout << "Please enter a list of numbers ";

	getline(cin , str_num);
	 // takes a complete line (discarding newline character as well)

	istringstream iss(str_num); 
	 // inserts string into a stream (you should learn streams they are useful)

	// now you can use this stream just as you would cin, which is a stream itself actually
	while(iss >> current_number)
		 numbers.push_back(current_number);

	cout << "How many elements do you wish to sum? ";
	
	int sum;
	cin >> sum;

	system("pause");

}

GL!

Thanks, will have a look at streams later today. The book i'm working through hasn't got that far yet , but will definately look them up later.

Darren.