Thread: Using a vector element as a string

I would like to use a function that takes a char array[] as argument.
Would it be possible to pass a vector element as a char array[] ?

Code:

vector <string> vLines;

CopyMemory((vLines.at(0)).c_str(), &iLength, sizeof(WORD));
SendMessage(hWin_2, EM_GETLINE, i, (LPARAM) (vLines.at(0)).c_str());

cout << vLines[0] <<endl;

You can pass a vector<char> as a char array. You can pass a string as a const char array. You can't pass a string as a non-const char array.

Your CopyMemory call is weird, it doesn't match what I would expect it to be if you're using Windows, so it's hard to say what you're doing. The line in red is correct if you're not changing the string (e.g. if it's the source). If you are changing the string, you might consider something like:

Code:

unsigned buffer_length = ???; // set buffer_length dynamically here
vector<char> buffer(buffer_length); // create buffer of appropriate size

My_Function(&buffer[0], buffer_length); // fill buffer from function

vLines.at(0).assign(buffer, buffer_length); // asign buffer contents to your string

Depending on what My_Function does there might be better solutions. For example if the buffer can be filled with a shorter, null-terminated string, you don't want to use assign there, you would make sure there was at least one null character at the end and assign with operator=.

Thanks a lot Daved!

Actually im trying to rewrite this function to c++ and im wondering what to use.

Dont know if i need vector of vector or just vector?

Code:

 int iCount;
     WORD iLength, iOffset;
     TCHAR **Lines;

     //Get Number of Lines in Edit Field
     iCount = SendMessage(hEdit, EM_GETLINECOUNT, 0, 0);

     //If Editbox is empty, exit function
     if(!iCount)

          return;

     Lines = new TCHAR*[iCount];

     //Populate 2D array, Lines[LineIndex][LineText]
     for(int i=0; i<iCount; i++)
     {    iOffset = SendMessage(hEdit, EM_LINEINDEX, i, 0);
          iLength = (WORD)SendMessage(hEdit, EM_LINELENGTH, iOffset, 0);
          Lines[i] = new TCHAR[iLength+sizeof(WORD)+1];
          CopyMemory(Lines[i], &iLength, sizeof(WORD));
          SendMessage(hEdit, EM_GETLINE, i, (LPARAM)Lines[i]);
          Lines[i][iLength] = '\0';
     }

Ladies and gents let me present to you the happiest man on earth: me.

I solved the problem!

Ok first of all i realised that i didnt need multidirectional array.

Then i used Cpjust's help in another thread and i solved the problem with a vector <char>.

string vs dynamic char array

Ps
Cpjust: vec.push_back( '\0' ); // I can't remember if this is required, but it doesn't hurt.

Apparrently its working without the '\0'. At least i dont have garbage at the end and nothing missing either.