Converting text file to binary

Hi, Im trying to write a program to read in a textfile and convert it its binary represntation. I was under the impression that c++ does this automatically if you construct an ofstream using ios_base::binary. Can someone tell me how to do this properly ? here is my code -

Code:

#include<iostream>
#include<fstream>
#include<string>

using namespace std;

int main()
{
	string filename;

	cout << "Enter Filename: ";
	cin >> filename;

	ifstream infile;
	infile.open(filename.c_str());
	if(infile.fail()){
		cout << "File not found\n"; exit(1);
	}
	else {
		cout << "Converting file..." << endl;
	}

	filename += "_b.txt";
	ofstream outfile(filename.c_str(),ios_base::binary);
	
	string buffer;
	while(getline(infile,buffer))
		outfile << buffer;

	cout << "File Conversion Complete.." << endl;

	outfile.close();
	infile.close();

	return 0;
}

Why do you not like your answer? (You might be stripping newlines out, perhaps.)

Oh sorry! I forgot to say, The program works fine except that the new file it creates is not in binary. It is same as the input file, however I want it to be non human readable.

So you're going to have to do something else. Binary files can be human readable, and if all they contain is text, then they very well will be. You will need to do some encrypting.

Oh, well now I'm confused. What exactly is the point of ios_base::binary then ? I checked both my files and they are absolutely identical and have the same file size as well.
Also, I remember wirting an array to a file in c once using the "wb" mode and all I could see when I opened the file was random characters..that is pretty much what I'm trying to do here. What is the reason for the unreadable text in the array ? and could someone tell me some simple encryption methods or point me to some good information/tutorial ? thanks!

Every files are "binary files". Text files are just a special case of binary files, where all the content are characters in some character encoding.

Also, if you are looking for a "simple" way to do encryption, you would be better to look for some library that does the work for you, or using an external program. Else, you might want to look at "Vigenere cipher", which is really simple to implement and will make your file looks like gibberish, but is breakable in most case.

Originally Posted by rocketman03

Oh, well now I'm confused. What exactly is the point of ios_base::binary then ? I checked both my files and they are absolutely identical and have the same file size as well.
Also, I remember wirting an array to a file in c once using the "wb" mode and all I could see when I opened the file was random characters..that is pretty much what I'm trying to do here. What is the reason for the unreadable text in the array ? and could someone tell me some simple encryption methods or point me to some good information/tutorial ? thanks!

In binary you are printing things exactly as they are stored in the computer. For text, that's not a surprise, since text is already stored in ASCII. For something like a double, what is printed (normally) as 4.75 would be stored internally as 0x40980000, which you might see as "(b ".