Clone an object in a polymorphic class?

TriKri · 10-10-2009, 07:05 AM

Hi, I have a question about cloning objects in polymorphic classes:

In a lab we are doing in school we are going to create an expression tree, looking for example like this when it's printed:

Code:

which represents the expression 5*7+6 in tree form. Each node in the tree is of a class called node, then there's a subclass called node_operator. Each class under node is supposed to have a clone function, so that it is possible to clone a whole tree by just cloning the node at the lowest level.

node_operator in turn, is an abstract class which have subclasses called node_plus, node_minus, node_times etc. Each object which is of a derived class from node_operator will have two and only two data members, left_node and right_node. To clone a object from any subclass of node_operator, it will be the exact same code:

Code:

node_x* node_x::clone() {
    return new node_x(left_child->clone(), right_child->clone());
}

Where x is the name operator. Since x is different for every subclass, the same function can't be used, hence we need a virtual clone function. What I would like to do is something like this (only having to write the function once instead of having to write almost the same code in every subclass):

Code:

virtual node_operator* clone();

...

virtual node_operator* node_operator::clone(){
    return new typeof(this*) (left_child->clone(), right_child->clone());
}

If only typeof would have existed in C++ (as it does in C) the code would have worked, and the function I mentioned above (that one with node_x) would have successfully been copied to every subclass node_x. But now typeof doesn't exist in C++. Can I use something else instead of typeof, or do I have to write the clone function in every subclass? Having to write the same code in every subclass feels bad. Besides, the risk of creating a bug will increase. Why did they remove typeof from the beginning, when they created C++ from C?

quzah · 10-10-2009, 07:17 AM

There is no typeof in standard C. Have you learned about templates yet? Maybe you could template it.

Quzah.

C_ntua · 10-10-2009, 10:50 AM

Quote:

Originally Posted by quzah

There is no typeof in standard C. Have you learned about templates yet? Maybe you could template it.

Can you give a pseudo-code how he would do that?

valaris · 10-10-2009, 01:53 PM

Sounds like a good use of the prototype pattern.
Prototype Design Pattern
There is the UML of how you could design your class structure.

Yes each class needs to know "how" to copy itself.

tabstop · 10-10-2009, 03:17 PM

Are you really supposed to print that for the expression tree? Why? The expression tree would be this:

Code:

TriKri · 10-11-2009, 06:39 AM

Expression trees can be displayed in many ways, it can also look like this:

Code:

        -- 5
       |
    -- *
   |   |
   |    -- 7
   |
-- +
   |
    -- 6

But the form I used in the first post was the way our supervisor used as an example, because it is the easiest to program.

tabstop · 10-11-2009, 12:50 PM

Quote:

Originally Posted by TriKri

Expression trees can be displayed in many ways, it can also look like this:

Code:

        -- 5
       |
    -- *
   |   |
   |    -- 7
   |
-- +
   |
    -- 6

But the form I used in the first post was the way our supervisor used as an example, because it is the easiest to program.

Oh I see sideways. I was reading it downwards instead of to the right. Carry on then.

As to that, C stole typeof from C++'s typeid, so that shouldn't really be a problem.

brewbuck · 10-11-2009, 01:24 PM

This is definitely a candidate for templatization.

Code:

template < typename Op >
class BinaryNode
{
public:
    BinaryNode( Node *lhs, Node *rhs )
      : mLhs( lhs ),
        mRhs( rhs )
    {
    }

    Value Evaluate() const
    {
        return Op::Evaluate( lhs->Evaluate(), rhs->Evaluate() );
    }

    BinaryNode *Clone() const
    {
        return new BinaryNode( mLhs->Clone(), mRhs->Clone() );
    }

private:
    Node *mLhs;
    Node *mRhs;
};

Now, you can define for instance:

Code:

class AdditionOperator
{
public:
    static Value Evaluate( Value lhs, Value rhs )
    {
        return lhs + rhs;
    }
};

And then:

Code:

typedef BinaryNode< AdditionOperator > AdditionNode;

Now, you just have to implement the operators themselves, and forget about cloning.

(My code is not exception safe. In general, none of the examples I give are exception safe unless otherwise claimed)

TriKri · 10-30-2009, 07:44 AM

Thank you brewbuck, I'll remember that next time I get in the same situation!

-Kristofer

10-10-2009, 07:05 AM	#1
TriKri Algorithm engineer Join Date: Jun 2006 Posts: 223	Clone an object in a polymorphic class? Hi, I have a question about cloning objects in polymorphic classes: In a lab we are doing in school we are going to create an expression tree, looking for example like this when it's printed: Code: 5 / * \ 7 / + \ 6 which represents the expression 57+6 in tree form. Each node in the tree is of a class called node, then there's a subclass called node_operator. Each class under node is supposed to have a clone function, so that it is possible to clone a whole tree by just cloning the node at the lowest level. node_operator in turn, is an abstract class which have subclasses called node_plus, node_minus, node_times etc. Each object which is of a derived class from node_operator will have two and only two data members, left_node and right_node. To clone a object from any subclass of node_operator, it will be the exact same code: Code: node_x node_x::clone() { return new node_x(left_child->clone(), right_child->clone()); } Where x is the name operator. Since x is different for every subclass, the same function can't be used, hence we need a virtual clone function. What I would like to do is something like this (only having to write the function once instead of having to write almost the same code in every subclass): Code: virtual node_operator* clone(); ... virtual node_operator* node_operator::clone(){ return new typeof(this*) (left_child->clone(), right_child->clone()); } If only typeof would have existed in C++ (as it does in C) the code would have worked, and the function I mentioned above (that one with node_x) would have successfully been copied to every subclass node_x. But now typeof doesn't exist in C++. Can I use something else instead of typeof, or do I have to write the clone function in every subclass? Having to write the same code in every subclass feels bad. Besides, the risk of creating a bug will increase. Why did they remove typeof from the beginning, when they created C++ from C? __________________ Come on, you can do it! b( ~_')
TriKri is offline

10-10-2009, 07:17 AM	#2
quzah +++ OK NO CARRIER Join Date: Oct 2001 Posts: 10,259	There is no typeof in standard C. Have you learned about templates yet? Maybe you could template it. Quzah. __________________ Hundreds of thousands of dipshits can't be wrong. Are you up for the suck?
quzah is offline

10-10-2009, 01:53 PM	#4
valaris Registered User Join Date: Jun 2008 Location: RING 0 Posts: 462	Sounds like a good use of the prototype pattern. Prototype Design Pattern There is the UML of how you could design your class structure. Yes each class needs to know "how" to copy itself.
valaris is offline

10-10-2009, 03:17 PM	#5
tabstop and the Hat of Guessing Join Date: Nov 2007 Posts: 8,740	Are you really supposed to print that for the expression tree? Why? The expression tree would be this: Code: + / \ / \ * 6 / \ / \ 5 7
tabstop is offline

10-11-2009, 06:39 AM	#6
TriKri Algorithm engineer Join Date: Jun 2006 Posts: 223	Expression trees can be displayed in many ways, it can also look like this: Code: -- 5 \| -- * \| \| \| -- 7 \| -- + \| -- 6 But the form I used in the first post was the way our supervisor used as an example, because it is the easiest to program. __________________ Come on, you can do it! b( ~_')
TriKri is offline

10-11-2009, 01:24 PM	#8
brewbuck Senior software engineer Join Date: Mar 2007 Location: Portland, OR Posts: 5,381	This is definitely a candidate for templatization. Code: template < typename Op > class BinaryNode { public: BinaryNode( Node lhs, Node rhs ) : mLhs( lhs ), mRhs( rhs ) { } Value Evaluate() const { return Op::Evaluate( lhs->Evaluate(), rhs->Evaluate() ); } BinaryNode Clone() const { return new BinaryNode( mLhs->Clone(), mRhs->Clone() ); } private: Node mLhs; Node mRhs; }; Now, you can define for instance: Code: class AdditionOperator { public: static Value Evaluate( Value lhs, Value rhs ) { return lhs + rhs; } }; And then: Code: typedef BinaryNode< AdditionOperator > AdditionNode; Now, you just have to implement the operators themselves, and forget about cloning. (My code is not exception safe. In general, none of the examples I give are exception safe unless otherwise claimed) __________________ "Congratulations on your purchase. To begin using your quantum computer, set the power switch to both off and on simultaneously."* -- raftpeople@slashdot
brewbuck is offline

10-30-2009, 07:44 AM	#9
TriKri Algorithm engineer Join Date: Jun 2006 Posts: 223	Thank you brewbuck, I'll remember that next time I get in the same situation! -Kristofer __________________ Come on, you can do it! b( ~_')
TriKri is offline

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Getting an error with OpenGL: collect2: ld returned 1 exit status	Lorgon Jortle	C++ Programming	6	05-08-2009 08:18 PM
Inventory tracking of dynamically allocated items	Mario F.	C++ Programming	11	07-23-2006 05:39 PM
Mmk, I give up, lets try your way. (Resource Management)	Shamino	Game Programming	31	01-18-2006 09:54 AM
My Window Class	Epo	Game Programming	2	07-10-2005 02:33 PM
C++ Class Object Collection	Visual Develope	C++ Programming	3	05-04-2002 04:48 PM