Thread: Problem deleting dynamically allocated char array

As the title states, I'm having problems deleting a dynamic character array. I run the program and it runs fine until I delete the character array that holds the player's name.

It gives me an error like this.

Code:

Debug Assertion Failed!

<directory to dbgdel.cpp> line 52

Expression: _BLOCK_TYPE_IS_VALID(pHead->nBlockUse)

Here is all the code that I believe to be related to the error

Code:

//in file Main.cpp
int main()
{
	CGame* Game = new CGame;
	Game->CreatePlayer();
	delete Game;
	Game = NULL;

	return 0;
}

Code:

//in file Game.cpp
CGame::~_CGame(void)
{
	CGame::CleanUp();
}

void CGame::CreatePlayer(void)
{
	char name[50];
	cout << "What is your name?\n";
	cout << ">";
	cin.getline(name, 50);
	m_Player->SetName(name);
	cout << "Your name is " << m_Player->GetName() << ".\n";
	cin.get();
}

void CGame::CleanUp(void)
{
	delete m_Player;
	m_Player = NULL;
}

Code:

//in file Player.cpp
CPlayer::_CPlayer(void)
{
	m_Name = new char[50];
}
CPlayer::~_CPlayer(void)
{
	CPlayer::CleanUp();
}

char* CPlayer::GetName(void)
{
	return m_Name;
}
void CPlayer::SetName(char* name)
{
	m_Name = name;
}

void CPlayer::CleanUp(void)
{
	delete[] m_Name;
	m_Name = NULL;
}

Is m_Name just a char *? If so, it is pointing to the local memory in the CreatePlayer() function, which means that (1) any attempt to use it outside that function will fail horribly and (2) it is not dynamically allocated memory and so should not be freed.

Ah I had forgot to make the temporary name variable dynamically allocated and then send it over. Thank you very much.

Why are you not using std::string?

I was going to but had problems using getline with string. That and I don't have much experience messing with c-style strings, so I decided to use them instead to become more familiar with them.

Originally Posted by Rubiks14

I was going to but had problems using getline with string.

Really? What sort of problems were you having with them?

Originally Posted by Rubiks14

That and I don't have much experience messing with c-style strings, so I decided to use them instead to become more familiar with them.

Bad idea. First of all, you should thoroughly practice using them with a 'test' program (and this really goes for anything you're not familiar with) before ever using them in your regular code. Otherwise, you're just setting yourself up for disaster. Second, the whole beauty of C++ is that you can leave all of those implemantation details to a higher level class (which is both better at managing memory and manipulation than some naive approach).