make improve this plzz???

Code:

---

#include<iostream.h>
void main()
{
        float sum,difference,product,qoutient,a,b;
        char mychoice,password,answer;
        cout<<"enter your password"<<endl;
        cin>>password;
        if(password=='v')
        {
                cout<<"access granted....."<<endl;
                cout<<"do you want to perform one of the four mathematical operations?"<<endl;
                cout<<"mychoice"<<endl;
                        cout<<"a for addition"<<endl;
                        cout<<"s for subtraction"<<endl;
                        cout<<"m for multiplication"<<endl;                       
                        cout<<"d for division"<<endl;
                        cout<<"enter your choice"<<endl;
                cin>>answer;
       
                while(answer=='Y')//(answer!='N')
                {
                        cout<<"mychoice"<<endl;
                        cout<<"a for addition"<<endl;
                        cout<<"s for subtraction"<<endl;
                        cout<<"m for multiplication"<<endl;                       
                        cout<<"d for division"<<endl;
                        cout<<"enter your choice"<<endl;
                        cin>>mychoice;
                        switch (mychoice)
                        {
                        case'a':
                                cout<<"enter first number"<<endl;
                                cin>>a;
                                cout<<"enter second number"<<endl;
                                cin>>b;
                                sum=a+b;
                                cout<<"the sum is:"<<sum<<endl;
                                cout<<"do you want to continue?"<<endl;
                                cin>>answer;
                                break;

                        case's':
                                cout<<"enter first number"<<endl;
                                cin>>a;
                                cout<<"enter second number"<<endl;
                                cin>>b;
                                difference=a-b;
                                cout<<"the difference is:"<<difference<<endl;
                                cout<<"do you want to continue?"<<endl;
                                cin>>answer;
                                break;


                        case'm':
                                cout<<"enter first number"<<endl;
                                cin>>a;
                                cout<<"enter second number"<<endl;
                                cin>>b;
                                product=a*b;
                                cout<<"the product is:"<<product<<endl;
                                cout<<"do you want to continue?"<<endl;
                                cin>>answer;
                                break;

                        case'd':
                                cout<<"enter first number"<<endl;
                                cin>>a;
                                cout<<"enter second number"<<endl;
                                cin>>b;
                                qoutient=a/b;
                                cout<<"the qoutient is:"<<qoutient<<endl;
                                cout<<"do you want to continue?"<<endl;
                                cin>>answer;
                                break;
                        default:
                                cout<<"invalid choice"<<endl;
                                break;
                        }
                }
        }
        else
                cout<<"invalid password!!"<<endl;
}

---

You've got to be joking...

First of all, you have to END your CODE with [/code] and I HOPE that's indented after your last topic 6 months ago.. which was basically the same thing.

http://cboard.cprogramming.com/cplus...hile-code.html

Why did you switch to iostream.h instead of just iostream, and void main instead of int main? iostream.h is deprecated. void main is incorrect.

P.S. You don't need "plzz," question marks (?), and exclamation marks (!) everywhere to get our attention.

1.Use code tags.
2. Never use void main.
3. Your code is unreadable, so can't suggest much.

Code:

---

int main()
{
}

---

There - Much better already!
Now it's a valid C++ program.

iostream.h is outdated header - change your compiler to modern one

And then there's the question - what do you want? Improvement how?

Quote:

---

Originally Posted by iMalc

Code:

---

int main()
{
}

---

There - Much better already!
Now it's a valid C++ program.

---

Eh, not quite. ;) main()'s return value is undefined.

Code:

---

int main()
{
  return 0;
}

---

Now it's good. :D

randyjhon143,
Besides what the others have already pointed out, your program is missing the using namespace std; line.
Oh, and writing your sentences in proper case is nicer for the user. ;)

I'm under the impression that it implicitly returns 0 if nothing else is specified?

Quote:

---

Originally Posted by Yarin

Eh, not quite. ;) main()'s return value is undefined.

Code:

---

int main()
{
  return 0;
}

---

Now it's good. :D

---

Um actually... From the C++ standard (if my sources are accurate)

Quote:

---

5 A return statement in main has the effect of leaving the main function (destroying any objects with automatic storage duration) and calling exit with the return value as the argument. If control reaches the end of main without encountering a return statement, the effect is that of executing return 0;

---

I.e. it was valid.

Mmm, guess so.

I do, though, prefer a return statement in all non-void functions, for readability.